Add support for bulkID in SCIM2 #393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modules/charon-core/src/main/java/org/wso2/charon3/core/protocol/BulkRequestProcessor.java
Show resolved
Hide resolved
modules/charon-core/src/main/java/org/wso2/charon3/core/protocol/BulkRequestProcessor.java
Outdated
Show resolved
Hide resolved
modules/charon-core/src/main/java/org/wso2/charon3/core/protocol/BulkRequestProcessor.java
Show resolved
Hide resolved
modules/charon-core/src/main/java/org/wso2/charon3/core/protocol/BulkRequestProcessor.java
Outdated
Show resolved
Hide resolved
modules/charon-core/src/main/java/org/wso2/charon3/core/protocol/BulkRequestProcessor.java
Show resolved
Hide resolved
modules/charon-core/src/main/java/org/wso2/charon3/core/protocol/BulkRequestProcessor.java
Outdated
Show resolved
Hide resolved
modules/charon-core/src/main/java/org/wso2/charon3/core/protocol/BulkRequestProcessor.java
Show resolved
Hide resolved
modules/charon-core/src/main/java/org/wso2/charon3/core/protocol/BulkRequestProcessor.java
Show resolved
Hide resolved
modules/charon-core/src/main/java/org/wso2/charon3/core/protocol/BulkRequestProcessor.java
Show resolved
Hide resolved
modules/charon-core/src/main/java/org/wso2/charon3/core/protocol/BulkRequestProcessor.java
Show resolved
Hide resolved
modules/charon-core/src/main/java/org/wso2/charon3/core/protocol/BulkRequestProcessor.java
Show resolved
Hide resolved
modules/charon-core/src/main/java/org/wso2/charon3/core/protocol/BulkRequestProcessor.java
Outdated
Show resolved
Hide resolved
AnuradhaSK
reviewed
Oct 13, 2023
modules/charon-core/src/main/java/org/wso2/charon3/core/encoder/JSONDecoder.java
Outdated
Show resolved
Hide resolved
AnuradhaSK
reviewed
Oct 14, 2023
modules/charon-core/src/main/java/org/wso2/charon3/core/protocol/BulkRequestProcessor.java
Outdated
Show resolved
Hide resolved
AnuradhaSK
reviewed
Oct 16, 2023
modules/charon-core/src/main/java/org/wso2/charon3/core/protocol/BulkRequestProcessor.java
Outdated
Show resolved
Hide resolved
AnuradhaSK
reviewed
Oct 16, 2023
modules/charon-core/src/main/java/org/wso2/charon3/core/protocol/BulkRequestProcessor.java
Outdated
Show resolved
Hide resolved
AnuradhaSK
reviewed
Oct 16, 2023
modules/charon-core/src/main/java/org/wso2/charon3/core/protocol/BulkRequestProcessor.java
Outdated
Show resolved
Hide resolved
9 tasks
AnuradhaSK
reviewed
Oct 20, 2023
modules/charon-core/src/main/java/org/wso2/charon3/core/protocol/BulkRequestProcessor.java
Outdated
Show resolved
Hide resolved
AnuradhaSK
reviewed
Oct 20, 2023
modules/charon-core/src/main/java/org/wso2/charon3/core/protocol/BulkRequestProcessor.java
Outdated
Show resolved
Hide resolved
|
PR builder started |
AnuradhaSK
approved these changes
Oct 20, 2023
|
PR builder completed |
|
PR builder started |
|
PR builder completed |
jenkins-is-staging
approved these changes
Oct 20, 2023
There was a problem hiding this comment.
Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/6589471554
lashinijay
reviewed
May 15, 2024
|
|
||
| switch (bulkRequestContent.getMethod()) { | ||
| case SCIMConstants.OperationalConstants.POST: | ||
| if (bulkRequestContent.getPath().contains(SCIMConstants.ROLE_ENDPOINT)) { |
There was a problem hiding this comment.
bulkRequestContent.getPath() could this be null?
There was a problem hiding this comment.
No. Before coming to the BulkRequestProcessor these bulkRequestContent objects are created in JSONDecoder. The requestType is set as the path of bulkRequestContent here. Therefore, path can only be null if requestType is null, but this check is done here and if the requestType is null an error is thrown.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue - wso2/product-is#3300
Per the SCIM2 specification, a client can perform multiple actions within a single bulk operation, such as creating a new user, forming a new group, and subsequently adding the recently created user to this group. To achieve this, the client must utilize the surrogate ID attribute, bulkId, to reference the user. Our system currently lacks support for this functionality. This implementation introduces support for the aforementioned feature.