Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide v2 role support for scim2/bulk API #394

Merged
merged 3 commits into from
Oct 24, 2023
Merged

Provide v2 role support for scim2/bulk API #394

merged 3 commits into from
Oct 24, 2023

Conversation

PasinduYeshan
Copy link
Contributor

@PasinduYeshan PasinduYeshan commented Oct 23, 2023 •
edited
Loading

@PasinduYeshan PasinduYeshan mentioned this pull request Oct 23, 2023
Merged
@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/6614873009

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/6614873009
Status: failure

AnuradhaSK
AnuradhaSK previously approved these changes Oct 23, 2023
View reviewed changes
@PasinduYeshan @AnuradhaSK
Update modules/charon-core/src/main/java/org/wso2/charon3/core/protoc…
44c1d91 
…ol/BulkRequestProcessor.java

Co-authored-by: Anuradha Karunarathna <anuradha199528@gmail.com>
@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/6622065356

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/6622065356
Status: failure

@PasinduYeshan
Copy link
Contributor Author

PR builder failed due to the following intermittent issue.

[ERROR] Tests run: 2068, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 6,685.518 s <<< FAILURE! - in TestSuite
2023-10-24T05:44:01.2890376Z [ERROR] testSAMLSSOLogin(org.wso2.identity.integration.test.saml.RegistryMountTestCase)  Time elapsed: 7.416 s  <<< FAILURE!
2023-10-24T05:44:01.2892850Z java.lang.AssertionError: SAML SSO Login failed for travelocity.com-registrymount expected:<true> but was:<false>
2023-10-24T05:44:01.2894632Z 	at org.wso2.identity.integration.test.saml.RegistryMountTestCase.testSAMLSSOLogin(RegistryMountTestCase.java:172)
2023-10-24T05:44:01.2895717Z 
2023-10-24T05:44:03.0360612Z [INFO] 
2023-10-24T05:44:03.0361367Z [INFO] Results:
2023-10-24T05:44:03.0362271Z [INFO] 
2023-10-24T05:44:03.0362637Z [ERROR] Failures: 
2023-10-24T05:44:03.0364268Z [ERROR]   RegistryMountTestCase.testSAMLSSOLogin:172 SAML SSO Login failed for travelocity.com-registrymount expected:<true> but was:<false>

@AnuradhaSK AnuradhaSK merged commit dbd0787 into wso2:master Oct 24, 2023
2 checks passed
@PasinduYeshan PasinduYeshan mentioned this pull request Oct 26, 2023
Closed
sadilchamishka
sadilchamishka reviewed Jun 10, 2024
View reviewed changes
modules/charon-core/src/main/java/org/wso2/charon3/core/protocol/BulkRequestProcessor.java
if (failOnError == 0) {
bulkResponseData.addRoleOperation(getBulkResponseContent(bulkRequestContent, userIdMappings,
roleResourceV2Manager));
} else {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can have else-if

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update the license header, when you send the commit.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed with #407.

@PasinduYeshan PasinduYeshan mentioned this pull request Jul 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sadilchamishka sadilchamishka sadilchamishka left review comments

@AnuradhaSK AnuradhaSK AnuradhaSK approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@PasinduYeshan @jenkins-is-staging @AnuradhaSK @sadilchamishka