address review comments

wso2 · Oct 13, 2023 · f07e325 · f07e325
1 parent c8a4828
commit f07e325
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/...carbon/identity/api/server/api/resource/v1/constants/APIResourceMgtEndpointConstants.java b/...carbon/identity/api/server/api/resource/v1/constants/APIResourceMgtEndpointConstants.java
@@ -30,7 +30,7 @@ public class APIResourceMgtEndpointConstants {
     private APIResourceMgtEndpointConstants() {
     }
 
-    public static final String API_RESOURCE_TYPE = "BUSINESS";
+    public static final String BUSINESS_API_RESOURCE_TYPE = "BUSINESS";
     public static final String SYSTEM_API_RESOURCE_TYPE = "SYSTEM";
     public static final String API_RESOURCE_MANAGEMENT_PREFIX = "API-RESOURCE-";
     public static final String API_RESOURCE_PATH_COMPONENT = "/api-resources";

diff --git a/...2/carbon/identity/api/server/api/resource/v1/core/ServerAPIResourceManagementService.java b/...2/carbon/identity/api/server/api/resource/v1/core/ServerAPIResourceManagementService.java
@@ -395,7 +395,7 @@ private APIResource createAPIResource(APIResourceCreationModel apIResourceCreati
                 .scopes(createScopes(apIResourceCreationModel.getScopes()))
                 .requiresAuthorization(apIResourceCreationModel.getRequiresAuthorization() != null ?
                         apIResourceCreationModel.getRequiresAuthorization() : true)
-                .type(APIResourceMgtEndpointConstants.API_RESOURCE_TYPE);
+                .type(APIResourceMgtEndpointConstants.BUSINESS_API_RESOURCE_TYPE);
         return apiResourceBuilder.build();
     }
 
@@ -479,9 +479,9 @@ private static Integer validatedLimit(Integer limit) throws APIError {
      *
      * @param apiResource API resource to be handled.
      */
-    private static void handleSystemAPI(APIResource apiResource) {
+    private void handleSystemAPI(APIResource apiResource) {
 
-        if (StringUtils.equals(apiResource.getType(), APIResourceMgtEndpointConstants.SYSTEM_API_RESOURCE_TYPE)) {
+        if (APIResourceMgtEndpointConstants.SYSTEM_API_RESOURCE_TYPE.equals(apiResource.getType())) {
             throw APIResourceMgtEndpointUtil.handleException(Response.Status.FORBIDDEN,
                     ErrorMessage.ERROR_CODE_SYSTEM_API_RESOURCE_NOT_MODIFIABLE);
         }