API structure was changed to obtain Access Token Audiences in GET response #391

gershom96 · 2022-09-07T09:01:56Z

Purpose

Adds REST API support for Access Token audiences.
Resolves issue6264, issue6263

Automation tests

Unit tests

Code coverage information
Integration tests

Details about the test cases and coverage

Security checks

Followed secure coding standards in http://wso2.com/technical-reports/wso2-secure-engineering-guidelines? yes/no
Ran FindSecurityBugs plugin and verified report? yes/no
Confirmed that this PR doesn't commit any keys, passwords, tokens, usernames, or other secrets? yes/no

Related PRs

wso2/carbon-identity-framework#4232
wso2-extensions/identity-inbound-auth-oauth#1902 (PR Tests are dependent on this PR being merged)
https://github.com/wso2-extensions/identity-migration-resources/pull/254

Migrations (if applicable)

Describe migration steps and platforms on which migration has been tested

Test environment

List all JDK versions, operating systems, databases, and browser/versions on which this feature/fix was tested

Learning

Describe the research phase and any blog posts, patterns, libraries, or add-ons you used to solve the problem.

…ponse

…n. This needs to be changed when the PR is merged again

...tion/management/v1/core/functions/application/inbound/oauth2/OAuthConsumerAppToApiModel.java

...tion/management/v1/core/functions/application/inbound/oauth2/ApiModelToOAuthConsumerApp.java

...tion/management/v1/core/functions/application/inbound/oauth2/OAuthConsumerAppToApiModel.java

.../org/wso2/carbon/identity/api/server/application/management/v1/AccessTokenConfiguration.java

...tion/management/v1/core/functions/application/inbound/oauth2/ApiModelToOAuthConsumerApp.java

.../org/wso2/carbon/identity/api/server/application/management/v1/AccessTokenConfiguration.java

...tion/management/v1/core/functions/application/inbound/oauth2/ApiModelToOAuthConsumerApp.java

...o2.carbon.identity.api.server.application.management.v1/src/main/resources/applications.yaml

…formation for the access token while legacy audiences are enabled

…iences enabled

…iour

gershom96 added 3 commits September 7, 2022 14:21

API structure was changed to obtain Access Token Audiences in GET res…

9e0f77e

…ponse

Added correct headers

9a88550

Updated pom to point to the right identitiy-inbound-auth-oauth versio…

2d76505

…n. This needs to be changed when the PR is merged again

gershom96 force-pushed the master branch 2 times, most recently from c6de6b1 to f18cf7c Compare September 8, 2022 02:04

Reverted header

846ec31

gershom96 force-pushed the master branch from f18cf7c to 846ec31 Compare September 8, 2022 02:06

Changed header

324fc23

dewniMW reviewed Sep 8, 2022

View reviewed changes

...tion/management/v1/core/functions/application/inbound/oauth2/OAuthConsumerAppToApiModel.java Outdated Show resolved Hide resolved

dewniMW reviewed Sep 8, 2022

View reviewed changes

...tion/management/v1/core/functions/application/inbound/oauth2/OAuthConsumerAppToApiModel.java Outdated Show resolved Hide resolved

dewniMW reviewed Sep 8, 2022

View reviewed changes

...tion/management/v1/core/functions/application/inbound/oauth2/OAuthConsumerAppToApiModel.java Outdated Show resolved Hide resolved

dewniMW reviewed Sep 8, 2022

View reviewed changes

...tion/management/v1/core/functions/application/inbound/oauth2/OAuthConsumerAppToApiModel.java Outdated Show resolved Hide resolved

gershom96 mentioned this pull request Sep 8, 2022

Added Audience parameters for Access Token wso2/identity-apps#3441

Closed

9 tasks

Carried out some suggestions

af6b257

dewniMW reviewed Sep 9, 2022

View reviewed changes

...tion/management/v1/core/functions/application/inbound/oauth2/ApiModelToOAuthConsumerApp.java Outdated Show resolved Hide resolved

dewniMW reviewed Sep 9, 2022

View reviewed changes

...tion/management/v1/core/functions/application/inbound/oauth2/OAuthConsumerAppToApiModel.java Show resolved Hide resolved

gershom96 force-pushed the master branch from 4363536 to 5f1a0a8 Compare September 9, 2022 05:59

Fixed header issues

5980db8

gershom96 force-pushed the master branch from 5f1a0a8 to 5980db8 Compare September 9, 2022 06:13

dewniMW reviewed Sep 12, 2022

View reviewed changes

.../org/wso2/carbon/identity/api/server/application/management/v1/AccessTokenConfiguration.java Outdated Show resolved Hide resolved

dewniMW reviewed Sep 12, 2022

View reviewed changes

...tion/management/v1/core/functions/application/inbound/oauth2/ApiModelToOAuthConsumerApp.java Show resolved Hide resolved

gershom96 force-pushed the master branch 2 times, most recently from c4c82ee to bf1b851 Compare September 12, 2022 07:47

dewniMW reviewed Sep 12, 2022

View reviewed changes

.../org/wso2/carbon/identity/api/server/application/management/v1/AccessTokenConfiguration.java Outdated Show resolved Hide resolved

dewniMW reviewed Sep 12, 2022

View reviewed changes

...tion/management/v1/core/functions/application/inbound/oauth2/ApiModelToOAuthConsumerApp.java Show resolved Hide resolved

gershom96 commented Oct 24, 2022

View reviewed changes

...tion/management/v1/core/functions/application/inbound/oauth2/ApiModelToOAuthConsumerApp.java Show resolved Hide resolved

gershom96 commented Oct 24, 2022

View reviewed changes

...o2.carbon.identity.api.server.application.management.v1/src/main/resources/applications.yaml Outdated Show resolved Hide resolved

gershom96 marked this pull request as draft October 25, 2022 05:34

Changed header files

9c5c09b

gershom96 force-pushed the master branch from 98e43c7 to 9c5c09b Compare October 28, 2022 10:18

gershom96 and others added 8 commits October 28, 2022 15:49

Merge branch 'master' of https://github.com/wso2/identity-api-server

3be794a

Merge branch 'wso2:master' into master

31d038d

Addressed issues raised in review

1be3762

Merge branch 'master' of github.com:gershom96/identity-api-server

46772f6

Merge branch 'wso2:master' into master

b02544a

Adding an Error Response if the API request body contains audience in…

b95f20c

…formation for the access token while legacy audiences are enabled

Handling access token audience values in API requests when legacy aud…

d7dea03

…iences enabled

Bumped oauth version

3973ca8

gershom96 marked this pull request as ready for review June 8, 2023 05:07

gershom96 added 5 commits June 16, 2023 14:12

Merged from upstream and resolved conflicts

d66d3ae

Updated APIs to remove functionality to support Legacy Audience behav…

013e86d

…iour

Resolved pom file

1dea844

API changes to accomadata curent audience separation implementation

0c41e0f

Fixed merge conflict

149dd8c

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

API structure was changed to obtain Access Token Audiences in GET response #391

API structure was changed to obtain Access Token Audiences in GET response #391

gershom96 commented Sep 7, 2022 •

edited

Loading

API structure was changed to obtain Access Token Audiences in GET response #391

Are you sure you want to change the base?

API structure was changed to obtain Access Token Audiences in GET response #391

Conversation

gershom96 commented Sep 7, 2022 • edited Loading

Purpose

Automation tests

Security checks

Related PRs

Migrations (if applicable)

Test environment

Learning

gershom96 commented Sep 7, 2022 •

edited

Loading