Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 16482 #479

Merged
merged 3 commits into from
Sep 1, 2023
Merged

Fix 16482 #479

merged 3 commits into from
Sep 1, 2023

Conversation

DMHP
Copy link
Contributor

@DMHP DMHP commented Aug 31, 2023

Purpose

To fix wso2/product-is#16482

@CLAassistant
Copy link

CLAassistant commented Aug 31, 2023

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ DMHP
❌ Hasanthi Dissanayake


Hasanthi Dissanayake seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@@ -294,6 +293,26 @@ private SubjectConfig buildSubjectClaimConfig(ServiceProvider application) {
return subjectConfig;
}

private void assignClaimForSubjectValue(ServiceProvider application, SubjectConfig subjectConfig) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a new line after this method signature.

Kanapriya
Kanapriya previously approved these changes Sep 1, 2023
@DMHP DMHP merged commit 84dbc8c into wso2:master Sep 1, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Defaulted username as the sub in claim configuration in sample applications
3 participants