Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add app_version field to get and patch api contracts #665

Merged
merged 3 commits into from
Oct 9, 2024
Merged

Add app_version field to get and patch api contracts #665

merged 3 commits into from
Oct 9, 2024

Conversation

mpmadhavig
Copy link
Contributor

Purpose

$subject to give support for introducing behavioral changing features to applications.

Related Issues

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/11240336616

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/11240336616
Status: failure

@mpmadhavig
Copy link
Contributor Author

PR builder started Link: https://github.com/wso2/product-is/actions/runs/11240336616

will be fixed with wso2/product-is#21232

RushanNanayakkara
RushanNanayakkara reviewed Oct 9, 2024
View reviewed changes
.../java/org/wso2/carbon/identity/api/server/application/management/v1/ApplicationListItem.java
@Valid
public String getApplicationVersion() {
return applicationVersion;
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing new line.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto generated code.

@mpmadhavig mpmadhavig merged commit c89b210 into wso2:master Oct 9, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RushanNanayakkara RushanNanayakkara RushanNanayakkara approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mpmadhavig @jenkins-is-staging @RushanNanayakkara