Skip to content

Commit

Permalink
Add design suggestions.
Browse files Browse the repository at this point in the history
  • Loading branch information
mpmadhavig committed Aug 27, 2024
1 parent 5f2b77c commit 088ed45
Showing 1 changed file with 57 additions and 69 deletions.
126 changes: 57 additions & 69 deletions features/admin.applications.v1/pages/application-edit.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -629,85 +629,74 @@ const ApplicationEditPage: FunctionComponent<ApplicationEditPageInterface> = (
return (
<Forms onSubmit={ handleBannerCheckBoxUpdate }>
<Grid>
<Typography component="div">
<Trans
i18nKey={
t("applications:forms.inboundOIDC.sections"
+ ".legacyApplicationTokens.fields."
+ "commonInstruction")
}>
Change the customer-end applications accordingly to recieve the below updates.
</Trans>
</Typography>
<ol>
{
!applicationInboundConfig
.useClientIdAsSubClaimForAppTokens && (
<li>
<Trans
i18nKey={
t("applications:forms.inboundOIDC.sections"
{
!applicationInboundConfig
.useClientIdAsSubClaimForAppTokens && (
<>
<Trans
i18nKey={
t("applications:forms.inboundOIDC.sections"
+ ".legacyApplicationTokens.fields."
+ "useClientIdAsSubClaimForAppTokens.instruction")
}
/>
<Field
ref={ useClientIdAsSubClaimForAppTokensElement }
name="useClientIdAsSubClaimForAppTokens"
required={ false }
type="checkbox"
disabled={ false }
value={ useClientIdAsSubClaimForAppTokens ?
[ "useClientIdAsSubClaimForAppTokens" ]
: [] }
readOnly={ false }
data-componentId={
`${ componentId }-use-client-id-as-sub-claim-for-app-tokens` }
children={ [
{
label: t("applications:forms.inboundOIDC.sections."
}
/>
<Field
ref={ useClientIdAsSubClaimForAppTokensElement }
name="useClientIdAsSubClaimForAppTokens"
required={ false }
type="checkbox"
disabled={ false }
value={ useClientIdAsSubClaimForAppTokens ?
[ "useClientIdAsSubClaimForAppTokens" ]
: [] }
readOnly={ false }
data-componentId={
`${ componentId }-use-client-id-as-sub-claim-for-app-tokens` }
children={ [
{
label: t("applications:forms.inboundOIDC.sections."
+ "legacyApplicationTokens.fields"
+ ".useClientIdAsSubClaimForAppTokens.label"),
value: "useClientIdAsSubClaimForAppTokens"
}
] }
listen={ (values: Map<string, FormValue>) => {

if ( values.get("useClientIdAsSubClaimForAppTokens")
.length > 0) {
setBannerSubmitDisabled(false);
value: "useClientIdAsSubClaimForAppTokens"
}
] }
listen={ (values: Map<string, FormValue>) => {

if ( values.get("useClientIdAsSubClaimForAppTokens")
.length > 0) {
setBannerSubmitDisabled(false);
} else {
if (values.get("omitUsernameInIntrospectionRespForAppTokens")
.length === 0) {
setBannerSubmitDisabled(true);
} else {
if (values.get("omitUsernameInIntrospectionRespForAppTokens")
.length === 0) {
setBannerSubmitDisabled(true);
} else {
setBannerSubmitDisabled(false);
}
setBannerSubmitDisabled(false);
}
setUseClientIdAsSubClaimForAppTokens(
!useClientIdAsSubClaimForAppTokens);
}
}
/>
<Hint>
{ t("applications:forms.inboundOIDC.sections.legacyApplicationTokens."
setUseClientIdAsSubClaimForAppTokens(
!useClientIdAsSubClaimForAppTokens);
}
}
/>
<Hint>
{ t("applications:forms.inboundOIDC.sections.legacyApplicationTokens."
+ "fields.useClientIdAsSubClaimForAppTokens.hint") }
</Hint>
</li>
)
}
{
(!applicationInboundConfig.omitUsernameInIntrospectionRespForAppTokens
</Hint>
</>
)
}
{
(!applicationInboundConfig.omitUsernameInIntrospectionRespForAppTokens
&& !applicationInboundConfig.useClientIdAsSubClaimForAppTokens) &&
(
<Divider hidden />
)
}
{
(!applicationInboundConfig
.omitUsernameInIntrospectionRespForAppTokens) &&
}
{
(!applicationInboundConfig
.omitUsernameInIntrospectionRespForAppTokens) &&
(
<li>
<>
<Trans
i18nKey={
t("applications:forms.inboundOIDC.sections"
Expand Down Expand Up @@ -756,10 +745,9 @@ const ApplicationEditPage: FunctionComponent<ApplicationEditPageInterface> = (
{ t("applications:forms.inboundOIDC.sections.legacyApplicationTokens."
+ "fields.omitUsernameInIntrospectionRespForAppTokens.hint") }
</Hint>
</li>
</>
)
}
</ol>
}
</Grid>
<Button
variant="contained"
Expand Down

0 comments on commit 088ed45

Please sign in to comment.