Fix review comments

wso2 · Oct 26, 2023 · 8998fa5 · 8998fa5
1 parent 04d4995
commit 8998fa5
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 5 deletions.
diff --git a/apps/console/src/features/applications/api/use-scopes-of-api-resources.ts b/apps/console/src/features/applications/api/use-scopes-of-api-resources.ts
@@ -33,8 +33,7 @@ import { AuthorizedPermissionListItemInterface } from "../models/api-authorizati
  * @throws `IdentityAppsApiException`
  */
 const useScopesOfAPIResources = <Data = AuthorizedPermissionListItemInterface[], Error = RequestErrorInterface>(
-    apiResourceId: string,
-    shouldFetch?: boolean
+    apiResourceId: string
 ): RequestResultInterface<Data, Error> => {
 
     const requestConfig: AxiosRequestConfig = {
@@ -46,7 +45,7 @@ const useScopesOfAPIResources = <Data = AuthorizedPermissionListItemInterface[],
         url: `${ store.getState().config.endpoints.apiResources }/${ apiResourceId }/scopes`
     };
 
-    const { data, error, isValidating, mutate } = useRequest<Data, Error>(shouldFetch ? requestConfig: null);
+    const { data, error, isValidating, mutate } = useRequest<Data, Error>(apiResourceId ? requestConfig: null);
 
     return {
         data,

diff --git a/apps/console/src/features/applications/components/api-authorization/scope-form.tsx b/apps/console/src/features/applications/components/api-authorization/scope-form.tsx
@@ -99,7 +99,7 @@ export const ScopeForm: FunctionComponent<ScopeFormInterface> = (
         data: currentAPIResourceScopeListData,
         isLoading: isCurrentAPIResourceScopeListDataLoading,
         error: currentAPIResourceScopeListFetchError
-    } = useScopesOfAPIResources(subscribedAPIResource?.id, subscribedAPIResource?.id != null);
+    } = useScopesOfAPIResources(subscribedAPIResource?.id);
 
     /**
      * The following useEffect is used to handle if any error occurs while fetching API resource scopes.

diff --git a/.../src/features/applications/components/api-authorization/wizard/authorize-api-resource.tsx b/.../src/features/applications/components/api-authorization/wizard/authorize-api-resource.tsx
@@ -116,7 +116,7 @@ export const AuthorizeAPIResource: FunctionComponent<AuthorizeAPIResourcePropsIn
         isLoading: isCurrentAPIResourceScopeListDataLoading,
         error: currentAPIResourceScopeListFetchError,
         mutate: mutatecurrentAPIResourceScopeList
-    } = useScopesOfAPIResources(selectedAPIResource?.id, selectedAPIResource?.id != null);
+    } = useScopesOfAPIResources(selectedAPIResource?.id);
 
     /**
      * The following useEffect is used to handle if any error occurs while fetching API resources.