Show Role Audience of Assigned Roles of the Group #4688
Conversation
| @@ -31,17 +30,21 @@ interface RenderChipInterface extends IdentifiableComponentInterface, ChipProps | |||
| */ | |||
| setActiveOption: (option: RolesMemberInterface) => void; | |||
| /** | |||
| * Primary text of the chip. | |||
| * Display name of the role | |||
There was a problem hiding this comment.
If we are updating the component properties specifically for displaying role information, let's also rename RenderChip and related interface names as well.
There was a problem hiding this comment.
Fixed with 8cb8bf2
| } = props; | ||
|
|
||
| const [ popoverAnchorEl, setPopoverAnchorEl ] = useState<Element>(null); | ||
| const [ , setPopoverAnchorEl ] = useState<Element>(null); |
There was a problem hiding this comment.
Can't we remove this as well?
There was a problem hiding this comment.
Fixed with 8cb8bf2
|
Can you add a screenshot on how it will display when assigned multiple org roles. |
| @@ -118,7 +118,10 @@ export const EditGroupRoles: FunctionComponent<EditGroupRolesPropsInterface> = ( | |||
| <RenderChip | |||
| { ...getTagProps({ index }) } | |||
| key={ index } | |||
| primaryText={ option.display } | |||
| primaryText={ "" } | |||
There was a problem hiding this comment.
Remove primaryText prop.
There was a problem hiding this comment.
Fixed with 8cb8bf2
| } = props; | ||
|
|
||
| const [ popoverAnchorEl, setPopoverAnchorEl ] = useState<Element>(null); | ||
| const [ , setPopoverAnchorEl ] = useState<Element>(null); |
| @@ -19,7 +19,6 @@ | |||
| import Chip, { ChipProps } from "@oxygen-ui/react/Chip"; | |||
| import { IdentifiableComponentInterface, RolesMemberInterface } from "@wso2is/core/models"; | |||
| import React, { FunctionComponent, ReactElement, SyntheticEvent, useState } from "react"; | |||
| import { ChipMoreDetails } from "./chip-more-details"; | |||
There was a problem hiding this comment.
Remove chip-more-details file as well.
There was a problem hiding this comment.
Fixed with 8cb8bf2
|
The following screenshot displays how the roles will be shown when there are multiple org audience roles. |
Purpose
Related Issues
Related PRs
Revised UI
Checklist
Security checks