Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding new DCR Application Settings Page #5964

Merged
merged 23 commits into from
Jun 24, 2024

Conversation

anjuchamantha
Copy link
Contributor

@anjuchamantha anjuchamantha commented Apr 16, 2024

Purpose

This PR adds a new page for Application Settings for DCR which contains tenant wise DCR configurations.

Screenshot 2024-05-22 at 5 40 10 PM

Related Issues

Related PRs

Backend PRs

wso2/carbon-identity-framework#5438
wso2-extensions/identity-inbound-auth-oauth#2344
wso2-extensions/identity-carbon-auth-rest#269
wso2/identity-api-server#583

Tests

  • Unit tests provided. (Add links if there are any)
  • Integration tests provided. (Add links if there are any)

Security checks

# Conflicts:
#	features/admin.applications.v1/api/applications-settings.ts
#	features/admin.applications.v1/api/use-get-dcr-configurations.ts
#	features/admin.applications.v1/pages/applications-settings.tsx
#	features/admin.applications.v1/pages/applications.tsx
@CLAassistant
Copy link

CLAassistant commented Apr 16, 2024

CLA assistant check
All committers have signed the CLA.

@pavinduLakshan
Copy link
Contributor

Seems there are some conflicts in couple of files. Please fix those as well :)

# Conflicts:
#	features/admin.applications.v1/pages/applications.tsx
#	features/admin.core.v1/configs/routes.tsx
@anjuchamantha
Copy link
Contributor Author

Seems there are some conflicts in couple of files. Please fix those as well :)

Fixed with 0bbb577

@pavinduLakshan
Copy link
Contributor

To avoid potential merge conflicts, we may be able to merge this PR with a feature config with disabled state.

@anjuchamantha anjuchamantha marked this pull request as ready for review June 14, 2024 04:55
@anjuchamantha anjuchamantha changed the title [WIP] Adding new DCR Application Settings Page Adding new DCR Application Settings Page Jun 14, 2024
@wso2-jenkins-bot
Copy link
Contributor

🦋 Changeset detected

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

@brionmario brionmario merged commit 62d460b into wso2:master Jun 24, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants