Use hook for fetching branding preference #5996
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedThe changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. |
pavinduLakshan
approved these changes
Apr 18, 2024
| @@ -48,13 +50,17 @@ const AIBrandingPreferenceProvider: FunctionComponent<AIBrandingPreferenceProvid | |||
|
|
|||
| const { children } = props; | |||
|
|
|||
| const { preference } = useBrandingPreference(); | |||
There was a problem hiding this comment.
Shall we update the PR description with the reason for opting out of retrieving branding preferences from the context?
Also, if we are not using the branding preferences from context anywhere, let's remove it from the context too.
Comment on lines
+60
to
+62
| const { | ||
| data: brandingPreference | ||
| } = useGetBrandingPreferenceResolve(tenantDomain); |
There was a problem hiding this comment.
Shouldn't we handle loading, error states?
|
Please link the issue as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
$subject
Related Issues
Related PRs
Checklist
Security checks