Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate API call and improve tab switching in SMS Providers #6405

Merged
merged 4 commits into from
Jun 7, 2024

Conversation

savindi7
Copy link
Contributor

@savindi7 savindi7 commented Jun 4, 2024

Purpose

$subject

Related Issues

Related PRs

Checklist

  • e2e cypress tests locally verified.
  • Manual test round performed and verified.
  • UX/UI review done on the final implementation.
  • Documentation provided. (Add links if there are any)
  • Unit tests provided. (Add links if there are any)
  • Integration tests provided. (Add links if there are any)

Security checks

JayaShakthi97
JayaShakthi97 previously approved these changes Jun 4, 2024
brionmario
brionmario previously approved these changes Jun 4, 2024
@savindi7 savindi7 dismissed stale reviews from brionmario and JayaShakthi97 via 671f414 June 4, 2024 16:24
@savindi7 savindi7 force-pushed the fix-sms-provider-tab-switch branch from baf5f6d to 671f414 Compare June 4, 2024 16:24
JayaShakthi97
JayaShakthi97 previously approved these changes Jun 4, 2024
brionmario
brionmario previously approved these changes Jun 4, 2024
@savindi7 savindi7 dismissed stale reviews from brionmario and JayaShakthi97 via b22b12c June 7, 2024 04:46
@savindi7 savindi7 force-pushed the fix-sms-provider-tab-switch branch from 671f414 to b22b12c Compare June 7, 2024 04:46
@wso2-jenkins-bot
Copy link
Contributor

🦋 Changeset detected

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

@savindi7 savindi7 merged commit 38a707f into wso2:master Jun 7, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants