Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add localization support for authentication and recovery endpoints #6406

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Add localization support for authentication and recovery endpoints #6406

wants to merge 6 commits into from
+134 −18

Conversation

AfraHussaindeen
Copy link
Contributor

@AfraHussaindeen AfraHussaindeen commented Jun 5, 2024 •
edited
Loading

pavinduLakshan
pavinduLakshan reviewed Jun 6, 2024
View reviewed changes
Copy link
Contributor

@pavinduLakshan pavinduLakshan left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove the unnecessary comments where the code is self explanatory.

PS: Let's add changeset as well

identity-apps-core/apps/authentication-portal/src/main/webapp/includes/localize.jsp Outdated Show resolved Hide resolved
identity-apps-core/apps/authentication-portal/src/main/webapp/includes/localize.jsp Outdated Show resolved Hide resolved
identity-apps-core/apps/authentication-portal/src/main/webapp/includes/localize.jsp Outdated Show resolved Hide resolved
identity-apps-core/apps/authentication-portal/src/main/webapp/includes/localize.jsp Outdated Show resolved Hide resolved
identity-apps-core/apps/recovery-portal/src/main/webapp/includes/localize.jsp Outdated Show resolved Hide resolved
identity-apps-core/apps/recovery-portal/src/main/webapp/includes/localize.jsp Outdated Show resolved Hide resolved
identity-apps-core/apps/recovery-portal/src/main/webapp/includes/localize.jsp Outdated Show resolved Hide resolved
AfraHussaindeen and others added 2 commits June 11, 2024 15:34
@AfraHussaindeen @JayaShakthi97
Add full stop
53c558c 
Co-authored-by: Jayashakthi Perera <jayashakthiperera@gmail.com>
@AfraHussaindeen
Add full stop
a939518
brionmario
brionmario reviewed Jun 14, 2024
View reviewed changes
identity-apps-core/apps/authentication-portal/src/main/webapp/includes/language-switcher.jsp
@@ -140,9 +140,6 @@
<link href="css/language-selector.css" rel="stylesheet">

<%
// Specify the file path
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ayeshajay Could you please have a look?

@AfraHussaindeen AfraHussaindeen mentioned this pull request Oct 22, 2024
Merged
@AfraHussaindeen @brionmario
Fix review comment
26a705f 
Co-authored-by: Brion Mario <brionbmp@gmail.com>
@wso2-jenkins-bot
Copy link
Contributor

🦋 Changeset detected

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

@codecov Codecov
Copy link

codecov bot commented Oct 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (master@16208c3). Learn more about missing BASE report.

Additional details and impacted files 
@@            Coverage Diff            @@
##             master    #6406   +/-   ##
=========================================
  Coverage          ?   31.79%           
=========================================
  Files             ?       41           
  Lines             ?      890           
  Branches          ?      204           
=========================================
  Hits              ?      283           
  Misses            ?      607           
  Partials          ?        0
Flag Coverage Δ
@wso2is/core 31.79% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavinduLakshan pavinduLakshan pavinduLakshan left review comments

@JayaShakthi97 JayaShakthi97 JayaShakthi97 left review comments

@brionmario brionmario brionmario left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Custom localization is not working properly
5 participants
@AfraHussaindeen @wso2-jenkins-bot @brionmario @JayaShakthi97 @pavinduLakshan