Bring back the logo configuration for enterprise identity providers #6440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
| @@ -359,8 +359,14 @@ export const identityProviderConfig: IdentityProviderConfig = { | |||
|
|
|||
| return identityClaimsHiddenAuthenticators.has(authenticatorId); | |||
| }, | |||
| hideLogoInputFieldInIdPGeneralSettingsForm(): boolean { | |||
| return true; | |||
| hideLogoInputFieldInIdPGeneralSettingsForm(templateId: string): boolean { | |||
There was a problem hiding this comment.
Let's move this to a util file. With the unification effort, we are trying to move away from extension configs.
pavinduLakshan
force-pushed
the
enable_idp_logo
branch
from
ec0d83a
to
6f3a6f0
Compare
🦋 Changeset detectedThe changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
$subject
Related Issues
Related PRs
Checklist
Security checks