Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[My Account] Add UI Support for Multiple Email Addresses and Mobile Numbers per User #6563

Merged
merged 35 commits into from
Nov 8, 2024

Conversation

PasinduYeshan
Copy link
Contributor

@PasinduYeshan PasinduYeshan commented Jul 10, 2024

Purpose

Add UI support for multiple email addresses and mobile numbers per user feature.

Multiple email addresses and mobile numbers config is enabled:

Screen.Recording.2024-11-05.at.13.03.38.mov

Multiple email addresses and mobile numbers config is disabled:

Screen.Recording.2024-07-08.at.17.19.25.mov

Related Issues

Related PRs

Checklist

  • e2e cypress tests locally verified.
  • Manual test round performed and verified.
  • UX/UI review done on the final implementation.
  • Documentation provided. (Add links if there are any)
  • Unit tests provided. (Add links if there are any)
  • Integration tests provided. (Add links if there are any)

Security checks

@pavinduLakshan pavinduLakshan changed the title Add UI Support for Multiple Email Addresses and Mobile Numbers per User [My Account] Add UI Support for Multiple Email Addresses and Mobile Numbers per User Jul 22, 2024
Copy link

codecov bot commented Oct 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 32.02%. Comparing base (f9090c4) to head (968e601).
Report is 125 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6563      +/-   ##
==========================================
+ Coverage   31.79%   32.02%   +0.22%     
==========================================
  Files          41       41              
  Lines         890      893       +3     
  Branches      220      220              
==========================================
+ Hits          283      286       +3     
  Misses        607      607              
Flag Coverage Δ
@wso2is/core 32.02% <100.00%> (+0.22%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
modules/core/src/constants/profile-constants.ts 95.65% <100.00%> (+0.65%) ⬆️

@PasinduYeshan
Copy link
Contributor Author

PasinduYeshan commented Oct 14, 2024

New behavior will only be applied in IS if following identity config is set to true explicitly in IS.
user_claim_update.enable_multiple_emails_and_mobile_numbers

{% if identity_mgt.user_claim_update.enable_multiple_emails_and_mobile_numbers is defined %}
        "isMultipleEmailsAndMobileNumbersEnabled": {{ identity_mgt.user_claim_update.enable_multiple_emails_and_mobile_numbers }},
{% endif %}

In cloud environment following deployment.config.json value should be set to true.

"isMultipleEmailsAndMobileNumbersEnabled": true

@PasinduYeshan
Copy link
Contributor Author

Updated UIs:
image

image

@pavinduLakshan
Copy link
Contributor

@PasinduYeshan there are some lint failures. Let's fix those too.

apps/myaccount/src/api/verify-mobile-smsotp.ts Outdated Show resolved Hide resolved
apps/myaccount/src/components/profile/profile.tsx Outdated Show resolved Hide resolved
apps/myaccount/src/components/profile/profile.tsx Outdated Show resolved Hide resolved
* @param schema - schema of the attribute
* @param value - value of the attribute
*/
const handleMultiValuedItemDelete = (schema: ProfileSchema, value: string) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we move this to a util file?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apps/myaccount/src/components/profile/profile.tsx Outdated Show resolved Hide resolved
apps/myaccount/src/components/profile/profile.tsx Outdated Show resolved Hide resolved
@wso2-jenkins-bot
Copy link
Contributor

🦋 Changeset detected

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

@PasinduYeshan PasinduYeshan merged commit 972887d into wso2:master Nov 8, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants