Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve IDVP provider UI issues #6646

Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/console/src/public/deployment.config.json
Original file line number Diff line number Diff line change
Expand Up @@ -642,7 +642,7 @@
"enabled": false,
"scopes": {
"create": [
"internal_idvp_create"
"internal_idvp_add"
],
"delete": [
"internal_idvp_delete"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
* under the License.
*/

import { IdentifiableComponentInterface } from "@wso2is/core/models";

Check warning on line 19 in features/admin.identity-verification-providers.v1/components/identity-verification-provider-edit.tsx

View workflow job for this annotation

GitHub Actions / ⬣ ESLint (STATIC ANALYSIS) (lts/*, 8.7.4)

incorrect header
import { ResourceTab, ResourceTabPaneInterface } from "@wso2is/react-components";
import React, { FunctionComponent, ReactElement, useEffect, useState } from "react";
import { TabProps } from "semantic-ui-react";
Expand Down Expand Up @@ -147,7 +147,7 @@
isLoading={ isLoading }
onUpdate={ onUpdate }
data-componentid={ `${ componentId }-configuration-settings` }
uiMetaData={ uiMetaData.pages.edit.settings }
uiMetaData={ uiMetaData?.common?.configProperties }
isReadOnly={ isReadOnly }
loader={ getContentLoader }
/>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -375,7 +375,7 @@ export const IdvpCreateWizard: FunctionComponent<IDVPCreateWizardInterface> = (
return nameValidationError;
}

for(const setting of uiMetaData?.pages?.edit?.settings) {
for(const setting of uiMetaData?.common?.configProperties) {
const configurationValidationError: string = performValidations( values[setting.name], setting);

if(configurationValidationError) {
Expand Down Expand Up @@ -406,7 +406,7 @@ export const IdvpCreateWizard: FunctionComponent<IDVPCreateWizardInterface> = (
data-componentid={ `${ componentId }-form-wizard-idvp-name` }
hint={ t("idvp:forms.generalDetails.name.hint") }
/>
{ renderFormUIWithMetadata(uiMetaData?.pages?.edit?.settings, idvpTemplate) }
{ renderFormUIWithMetadata(uiMetaData?.common?.configProperties, idvpTemplate) }
</WizardPage>);
};

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
* specific language governing permissions and limitations
* under the License.
*/
import { FormFieldMessage } from "@wso2is/form";

Check warning on line 18 in features/admin.identity-verification-providers.v1/models/ui-metadata.ts

View workflow job for this annotation

GitHub Actions / ⬣ ESLint (STATIC ANALYSIS) (lts/*, 8.7.4)

incorrect header

/**
* Model that represent an input field in the UI metadata for an IDVP. It contains the
Expand Down Expand Up @@ -44,12 +44,8 @@
* to render the configuration settings section when creating and editing an IDVP.
*/
export interface UIMetaDataForIDVP {
pages: {
edit: {
settings: InputFieldMetadata[];
general?: InputFieldMetadata[];
attributes?: InputFieldMetadata[];
};
common: {
configProperties: InputFieldMetadata[];
}
}

Expand Down
Loading