Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce JWT Access Token Attributes #6730

Open
wants to merge 24 commits into
base: master
Choose a base branch
from

Conversation

shashimalcse
Copy link
Contributor

@shashimalcse shashimalcse commented Aug 6, 2024

Purpose

$subject

Related Issues

New Applications:
Screenshot 2024-08-22 at 13 38 12

Existing Application (Upgrade path):
Screenshot 2024-08-22 at 13 37 54

Related PRs

  • N/A

Checklist

  • e2e cypress tests locally verified. (for internal contributers)
  • Manual test round performed and verified.
  • UX/UI review done on the final implementation.
  • Documentation provided. (Add links if there are any)
  • Relevant backend changes deployed and verified
  • Unit tests provided. (Add links if there are any)

Security checks

Copy link
Contributor

@pavinduLakshan pavinduLakshan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add changeset and fix eslint issues

@Achintha444
Copy link
Contributor

Increase the padding between the token type and the warning message

@shashimalcse
Copy link
Contributor Author

Increase the padding between the token type and the warning message

fixed

@wso2-jenkins-bot
Copy link
Contributor

🦋 Changeset detected

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

@himeshsiriwardana
Copy link

The message, as discussed, is now clear. But the text will need to be properly formatted to improve readability. can we separate the text into sections.

previous behavior
new behavior
important info

Just a line separator between these points will suffice.

furthermore,

  • User Attributes is the section. not User.
  • Previously, all attributes marked as requested in the application's User Attributes section, referred to as requested attributes below, were ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants