-
Notifications
You must be signed in to change notification settings - Fork 254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[🧹 UNIFICATION CLEANUP] Refactor extensions/components
directory
#6882
base: master
Are you sure you want to change the base?
Conversation
bd23e5d
to
2bccd03
Compare
cb3df77
to
7fe5d52
Compare
extensions/components
directory
const { data, error, isValidating, mutate } = useRequest<Data, Error>( | ||
requestConfig | ||
); | ||
|
||
return { | ||
data, | ||
error, | ||
isLoading: !data && !error, | ||
isValidating, | ||
mutate | ||
}; | ||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moving forward we can directly use isLoading
property from swr hook. Please check other places as well
const { data, error, isValidating, mutate } = useRequest<Data, Error>( | |
requestConfig | |
); | |
return { | |
data, | |
error, | |
isLoading: !data && !error, | |
isValidating, | |
mutate | |
}; | |
}; | |
const { data, error, isLoading, isValidating, mutate } = useRequest<Data, Error>( | |
requestConfig | |
); | |
return { | |
data, | |
error, | |
isLoading, | |
isValidating, | |
mutate | |
}; | |
}; |
@@ -1,5 +1,5 @@ | |||
/** | |||
* Copyright (c) 2020, WSO2 LLC. (https://www.wso2.com). All Rights Reserved. | |||
* Copyright (c) 2022, WSO2 LLC. (https://www.wso2.com). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* Copyright (c) 2022, WSO2 LLC. (https://www.wso2.com). | |
* Copyright (c) 2022-2024, WSO2 LLC. (https://www.wso2.com). |
@@ -0,0 +1,73 @@ | |||
/** | |||
* Copyright (c) 2022, WSO2 LLC. (https://www.wso2.com). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* Copyright (c) 2022, WSO2 LLC. (https://www.wso2.com). | |
* Copyright (c) 2024, WSO2 LLC. (https://www.wso2.com). |
/** | ||
* Add sms notification senders with name SMSPublisher. | ||
* | ||
* @returns A promise containing the response. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* @returns A promise containing the response. | |
* @returns A promise containing the response. |
🦋 Changeset detectedThe changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6882 +/- ##
=======================================
Coverage 31.79% 31.79%
=======================================
Files 41 41
Lines 890 890
Branches 204 215 +11
=======================================
Hits 283 283
+ Misses 607 557 -50
- Partials 0 50 +50
Flags with carried forward coverage won't be shown. Click here to find out more. |
Purpose
Completely refactor the
admin.extensions.v1/components
directly and move the logic to related features.Related Issues
Related PRs
Checklist
Security checks