Improve email domain discovery page to incorporate new configuration for enabling email domain discovery for self-registration #7084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7084 +/- ##
==========================================
+ Coverage 31.79% 32.02% +0.22%
==========================================
Files 41 41
Lines 890 893 +3
Branches 220 215 -5
==========================================
+ Hits 283 286 +3
Misses 557 557
Partials 50 50
Flags with carried forward coverage won't be shown. Click here to find out more. |
Yasasr1
force-pushed
the
b2b-self-signup-config
branch
from
4fad846
to
9d66740
Compare
Yasasr1
commented
Nov 12, 2024
| @@ -36,7 +36,8 @@ import { | |||
| * @returns SWR response object containing the data, error, isValidating, mutate. | |||
| */ | |||
| const useGetOrganizationDiscoveryConfig = < | |||
| Data = OrganizationDiscoveryConfigInterface & { isOrganizationDiscoveryEnabled: boolean }, | |||
| Data = OrganizationDiscoveryConfigInterface & { isOrganizationDiscoveryEnabled: boolean, | |||
There was a problem hiding this comment.
Add these to the OrganizationDiscoveryConfigInterface
Yasasr1
commented
Nov 12, 2024
|
|
||
| if ((data as OrganizationDiscoveryConfigInterface)?.properties) { | ||
| (data as OrganizationDiscoveryConfigInterface).properties?.forEach( | ||
| (property: OrganizationDiscoveryConfigPropertyInterface) => { | ||
| if (property.key === "emailDomain.enable") { | ||
| if (property.key === "emailDomain.enable" && property.value === "true") { |
Yasasr1
commented
Nov 12, 2024
| @@ -0,0 +1,15 @@ | |||
| .discoverable-organizations-list-layout { | |||
Yasasr1
commented
Nov 12, 2024
| align-items: center; | ||
| gap: 10px; | ||
|
|
||
| >.ui.grid { |
Yasasr1
commented
Nov 12, 2024
| onListItemLimitChange: (limit: number) => void; | ||
| onListOffsetChange: (offset: number) => void; | ||
| onSearchQueryChange: (query: string) => void; | ||
|
|
Yasasr1
commented
Nov 12, 2024
| * Default props for the component. | ||
| */ | ||
| DiscoverableOrganizationsListLayout.defaultProps = { | ||
| "data-componentid": "discoverable-organizations-list-layout" |
Yasasr1
commented
Nov 12, 2024
| [ featureConfig, allowedScopes ] | ||
| ); | ||
| const isEmailDomainDiscoveryForSelfRegFeatureEnabled: boolean = !featureConfig?.organizationDiscovery?. | ||
| disabledFeatures?.includes("organizationDiscovery.emailDomainDiscoveryForSelfReg"); |
There was a problem hiding this comment.
use FEATURE_DICTIONARY constant
| onListItemLimitChange: (limit: number) => void; | ||
| onListOffsetChange: (offset: number) => void; | ||
| onSearchQueryChange: (query: string) => void; | ||
|
|
| ), | ||
| [ featureConfig, allowedScopes ] | ||
| ); | ||
| const isEmailDomainDiscoveryForSelfRegFeatureEnabled: boolean = !featureConfig?.organizationDiscovery?. |
There was a problem hiding this comment.
use isFeatureEnabled from core module
Yasasr1
commented
Nov 12, 2024
| * Fetch the self-registration configuration. | ||
| */ | ||
| useEffect(() => { | ||
| getConnectorDetails(ServerConfigurationsConstants.USER_ONBOARDING_CONNECTOR_ID, |
There was a problem hiding this comment.
use a swr hook to fetch the properties
Yasasr1
commented
Nov 12, 2024
|
|
||
| updateData.properties.push({ | ||
| key: "emailDomain.enable", | ||
| value: isOrganizationDiscoveryEnabled ? "true" : "false" |
There was a problem hiding this comment.
convert to string. check other places
Yasasr1
force-pushed
the
b2b-self-signup-config
branch
from
adcb98a
to
859fbcd
Compare
Yasasr1
force-pushed
the
b2b-self-signup-config
branch
from
859fbcd
to
ba5ced4
Compare
🦋 Changeset detectedThe changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Following improvements will be made to the existing email domain discovery page
Related issue