Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix saving issue when a custom layout is not configured for application branding #7140

Merged
merged 5 commits into from
Dec 3, 2024

Conversation

dasuni-30
Copy link
Contributor

Purpose

Fix saving issue when a custom layout is not configured for application branding

Related Issues

  • N/A

Related PRs

  • N/A

Checklist

  • e2e cypress tests locally verified. (for internal contributers)
  • Manual test round performed and verified.
  • UX/UI review done on the final implementation.
  • Documentation provided. (Add links if there are any)
  • Relevant backend changes deployed and verified
  • Unit tests provided. (Add links if there are any)
  • Integration tests provided. (Add links if there are any)

Security checks

Copy link

codecov bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 32.02%. Comparing base (d71e795) to head (d75068c).
Report is 441 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7140   +/-   ##
=======================================
  Coverage   32.02%   32.02%           
=======================================
  Files          41       41           
  Lines         893      893           
  Branches      220      215    -5     
=======================================
  Hits          286      286           
+ Misses        587      557   -30     
- Partials       20       50   +30     
Flag Coverage Δ
@wso2is/core 32.02% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 9 files with indirect coverage changes

@wso2-jenkins-bot
Copy link
Contributor

🦋 Changeset detected

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

@dasuni-30 dasuni-30 merged commit 415fd49 into wso2:master Dec 3, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants