Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚧 [WIP][NEW SIGNUP] Update property panel #7184

Merged
merged 23 commits into from
Dec 9, 2024

Conversation

brionmario
Copy link
Member

@brionmario brionmario commented Dec 6, 2024

Purpose

This pull request includes significant changes to the features/admin.authentication-flow-builder-core.v1 module, primarily focusing on renaming and refactoring components and hooks to align with the new flow-builder-core naming convention. Additionally, several components have been removed. Below is a summary of the most important changes:

Renaming and Refactoring:

  • features/admin.authentication-flow-builder-core.v1/api/use-get-authentication-flow-builder-core-elements.ts was renamed to features/admin.flow-builder-core.v1/api/use-get-flow-builder-core-elements.ts, and all references within the file were updated accordingly. [1] [2] [3]
  • features/admin.authentication-flow-builder-core.v1/components/decorated-visual-flow.tsx was renamed to features/admin.flow-builder-core.v1/components/decorated-visual-flow.tsx, and component names within the file were updated to match the new naming convention. [1] [2]
  • features/admin.authentication-flow-builder-core.v1/components/elements-panel/element-panel-draggable-node.scss was renamed to features/admin.flow-builder-core.v1/components/element-panel/element-panel-draggable-node.scss, and class names within the file were updated. [1] [2]

Component Removal:

  • Removed the ElementProperties component from features/admin.authentication-flow-builder-core.v1/components/element-properties/element-properties.tsx.
  • Removed the CommonNodeFactory component from features/admin.authentication-flow-builder-core.v1/components/nodes/common-node-factory.tsx.
  • Removed the StepNode component from features/admin.authentication-flow-builder-core.v1/components/nodes/step-node.tsx.

Related Issues

Related PRs

  • N/A

Checklist

  • e2e cypress tests locally verified. (for internal contributers)
  • Manual test round performed and verified.
  • UX/UI review done on the final implementation.
  • Documentation provided. (Add links if there are any)
  • Relevant backend changes deployed and verified
  • Unit tests provided. (Add links if there are any)
  • Integration tests provided. (Add links if there are any)

Security checks

@brionmario brionmario changed the base branch from master to new-signup December 6, 2024 06:35
@brionmario brionmario changed the title Feat sign up composer 🚧 [WIP][NEW SIGNUP] Add property panel functionality Dec 6, 2024
@brionmario brionmario marked this pull request as draft December 6, 2024 06:36
Copy link

codecov bot commented Dec 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 32.02%. Comparing base (1237023) to head (1b2bc7e).
Report is 26 commits behind head on new-signup.

Additional details and impacted files
@@             Coverage Diff             @@
##           new-signup    #7184   +/-   ##
===========================================
  Coverage       32.02%   32.02%           
===========================================
  Files              41       41           
  Lines             893      893           
  Branches          215      220    +5     
===========================================
  Hits              286      286           
  Misses            557      557           
  Partials           50       50           
Flag Coverage Δ
@wso2is/core 32.02% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@brionmario brionmario changed the title 🚧 [WIP][NEW SIGNUP] Add property panel functionality 🚧 [WIP][NEW SIGNUP] Update property panel Dec 9, 2024
@brionmario brionmario marked this pull request as ready for review December 9, 2024 04:17
@brionmario
Copy link
Member Author

Ignore the lint warnings in the RichText component for now since that'll be pushed to Oxygen UI side after cleaning up.

@brionmario brionmario merged commit 58a88d7 into wso2:new-signup Dec 9, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants