-
Notifications
You must be signed in to change notification settings - Fork 259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🚧 [WIP][NEW SIGNUP] Update property panel #7184
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brionmario
changed the title
Feat sign up composer
🚧 [WIP][NEW SIGNUP] Add property panel functionality
Dec 6, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## new-signup #7184 +/- ##
===========================================
Coverage 32.02% 32.02%
===========================================
Files 41 41
Lines 893 893
Branches 215 220 +5
===========================================
Hits 286 286
Misses 557 557
Partials 50 50
Flags with carried forward coverage won't be shown. Click here to find out more. |
brionmario
changed the title
🚧 [WIP][NEW SIGNUP] Add property panel functionality
🚧 [WIP][NEW SIGNUP] Update property panel
Dec 9, 2024
Ignore the lint warnings in the |
NipuniBhagya
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request includes significant changes to the
features/admin.authentication-flow-builder-core.v1
module, primarily focusing on renaming and refactoring components and hooks to align with the newflow-builder-core
naming convention. Additionally, several components have been removed. Below is a summary of the most important changes:Renaming and Refactoring:
features/admin.authentication-flow-builder-core.v1/api/use-get-authentication-flow-builder-core-elements.ts
was renamed tofeatures/admin.flow-builder-core.v1/api/use-get-flow-builder-core-elements.ts
, and all references within the file were updated accordingly. [1] [2] [3]features/admin.authentication-flow-builder-core.v1/components/decorated-visual-flow.tsx
was renamed tofeatures/admin.flow-builder-core.v1/components/decorated-visual-flow.tsx
, and component names within the file were updated to match the new naming convention. [1] [2]features/admin.authentication-flow-builder-core.v1/components/elements-panel/element-panel-draggable-node.scss
was renamed tofeatures/admin.flow-builder-core.v1/components/element-panel/element-panel-draggable-node.scss
, and class names within the file were updated. [1] [2]Component Removal:
ElementProperties
component fromfeatures/admin.authentication-flow-builder-core.v1/components/element-properties/element-properties.tsx
.CommonNodeFactory
component fromfeatures/admin.authentication-flow-builder-core.v1/components/nodes/common-node-factory.tsx
.StepNode
component fromfeatures/admin.authentication-flow-builder-core.v1/components/nodes/step-node.tsx
.Related Issues
Related PRs
Checklist
Security checks