Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Rules Component #7254

Merged
merged 19 commits into from
Jan 6, 2025
Merged

Add Rules Component #7254

merged 19 commits into from
Jan 6, 2025

Conversation

jeradrutnam
Copy link
Member

@jeradrutnam jeradrutnam commented Jan 3, 2025

Purpose

$subject + some improvements to the composer UI

Note: Rule component is still under development. This is the initial update on moving the feature with some supporting UIs.

Test need to add.

Related Issues

  • N/A

Related PRs

  • N/A

Checklist

  • e2e cypress tests locally verified. (for internal contributers)
  • Manual test round performed and verified.
  • UX/UI review done on the final implementation.
  • Documentation provided. (Add links if there are any)
  • Relevant backend changes deployed and verified
  • Unit tests provided. (Add links if there are any)
  • Integration tests provided. (Add links if there are any)

Security checks

@jeradrutnam jeradrutnam marked this pull request as ready for review January 4, 2025 14:53
@jeradrutnam jeradrutnam requested a review from brionmario January 4, 2025 14:56
@jeradrutnam jeradrutnam changed the title [WIP] Add Rules Component Add Rules Component Jan 4, 2025
Copy link

codecov bot commented Jan 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 32.02%. Comparing base (3956034) to head (21cd0ac).
Report is 21 commits behind head on new-signup.

Additional details and impacted files
@@             Coverage Diff             @@
##           new-signup    #7254   +/-   ##
===========================================
  Coverage       32.02%   32.02%           
===========================================
  Files              41       41           
  Lines             893      893           
  Branches          220      215    -5     
===========================================
  Hits              286      286           
+ Misses            587      557   -30     
- Partials           20       50   +30     
Flag Coverage Δ
@wso2is/core 32.02% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 8 files with indirect coverage changes

@jeradrutnam jeradrutnam merged commit 14244f6 into wso2:new-signup Jan 6, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants