Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing TLS secretName #585

Open
wants to merge 1 commit into
base: 4.2.x
Choose a base branch
from

Conversation

Nickmman
Copy link

Purpose

Resolves the issue where TLS spec is broken, it is missing the required secretName.

Goals

Ingress objects get created properly.

Approach

Adding secretName, prefixed with tls-, completed via the hostname being used in each Ingress objects.
Also, adjusted indentation to follow Kubernetes documentation.

User stories

Summary of user stories addressed by this change>

Release note

Add missing TLS secretName to Ingress.

Documentation

N/A - Value is automatically calculated.

Training

Link to the PR for changes to the training content in https://github.com/wso2/WSO2-Training, if applicable

Certification

Type “Sent” when you have provided new/updated certification questions, plus four answers for each question (correct answer highlighted in bold), based on this change. Certification questions/answers should be sent to certification@wso2.com and NOT pasted in this PR. If there is no impact on certification exams, type “N/A” and explain why.

Marketing

Link to drafts of marketing content that will describe and promote this feature, including product page changes, technical articles, blog posts, videos, etc., if applicable

Automation tests

  • Unit tests

    Code coverage information

  • Integration tests

    Details about the test cases and coverage

Security checks

Samples

Currently deploying via ArgoCD, Ingresses currently fail to be created, due to Skipped a TLS block: spec.tls[0].secretName: Required value

Related PRs

List any other related PRs

Migrations (if applicable)

Describe migration steps and platforms on which migration has been tested

Test environment

List all JDK versions, operating systems, databases, and browser/versions on which this feature/fix was tested

Learning

Describe the research phase and any blog posts, patterns, libraries, or add-ons you used to solve the problem.

Signed-off-by: Nicolas Pais <nick@nickserver.net>
@CLAassistant
Copy link

CLAassistant commented Jun 29, 2023

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants