Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Resolves the issue where TLS spec is broken, it is missing the required secretName.
Goals
Ingress objects get created properly.
Approach
Adding secretName, prefixed with
tls-
, completed via the hostname being used in each Ingress objects.Also, adjusted indentation to follow Kubernetes documentation.
User stories
Release note
Add missing TLS secretName to Ingress.
Documentation
N/A - Value is automatically calculated.
Training
Certification
Marketing
Automation tests
Security checks
Samples
Currently deploying via ArgoCD, Ingresses currently fail to be created, due to
Skipped a TLS block: spec.tls[0].secretName: Required value
Related PRs
Migrations (if applicable)
Test environment
Learning