Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(react): add Switch component #181

Merged
merged 3 commits into from
Nov 1, 2023
Merged

feat(react): add Switch component #181

merged 3 commits into from
Nov 1, 2023

Conversation

pavinduLakshan
Copy link
Contributor

@pavinduLakshan pavinduLakshan commented Oct 31, 2023 •
edited
Loading

Purpose

$subject

Screen.Recording.2023-11-01.at.11.22.43.mov

Related Issues

Related PRs

  • N/A

Checklist

  • UX/UI review done on the final implementation.
  • Story provided. (Add screenshots)
  • Manual test round performed and verified.
  • Unit tests provided. (Add links if there are any)
  • Documentation provided. (Add links if there are any)

Security checks

@pavinduLakshan pavinduLakshan marked this pull request as draft October 31, 2023 07:10
@pavinduLakshan pavinduLakshan force-pushed the switch_component branch 2 times, most recently from e4f811c to 892bea3 Compare October 31, 2023 08:11
@pavinduLakshan pavinduLakshan marked this pull request as ready for review October 31, 2023 08:12
@pavinduLakshan pavinduLakshan mentioned this pull request Oct 31, 2023
Open
73 tasks
@savindi7
Copy link
Contributor

savindi7 commented Nov 1, 2023

we need to change the commit messages according to the guidelines https://github.com/wso2/oxygen-ui/blob/main/CONTRIBUTING.md#commit-message-guidelines @pavinduLakshan

@pavinduLakshan
Copy link
Contributor Author

we need to change the commit messages according to the guidelines https://github.com/wso2/oxygen-ui/blob/main/CONTRIBUTING.md#commit-message-guidelines @pavinduLakshan

Fixed

@savindi7
Copy link
Contributor

savindi7 commented Nov 1, 2023

Screenshot 2023-11-01 at 11 14 31

Not sure why it seems like the switch button isn't aligned to the center. @pavinduLakshan

@pavinduLakshan
Copy link
Contributor Author

Screenshot 2023-11-01 at 11 14 31 Not sure why it seems like the switch button isn't aligned to the center. @pavinduLakshan

Fixed the issue. Thanks 🙌

@savindi7 savindi7 changed the title feat(react): Add Switch component feat(react): add Switch component Nov 1, 2023
@pavinduLakshan pavinduLakshan merged commit c499687 into wso2:main Nov 1, 2023
7 checks passed
@brionmario brionmario changed the title feat(react): add Switch component feat(react): add Switch component Jan 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@savindi7 savindi7 savindi7 approved these changes

@brionmario brionmario Awaiting requested review from brionmario

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pavinduLakshan @savindi7