Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Config Values for Enable SHA-256 Hashing Algorithm #13444

Merged
merged 2 commits into from
Mar 28, 2024

Conversation

hisanhunais
Copy link
Contributor

@hisanhunais hisanhunais commented Mar 25, 2024

Purpose

With [1] and [2], the support for SHA-256 was given for certificate hashing algorithm in backend JWT generation. To enable this support, a config was provided. This PR provides the default value for the config and add this config to the deployment.toml by commenting its value

[1] wso2/carbon-apimgt#12365
[2] wso2/carbon-apimgt#12387

Copy link

codecov bot commented Mar 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 24.29%. Comparing base (93e2009) to head (131cad0).
Report is 7 commits behind head on master.

❗ Current head 131cad0 differs from pull request most recent head 0d67e24. Consider uploading reports for the commit 0d67e24 to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #13444      +/-   ##
============================================
+ Coverage     20.27%   24.29%   +4.01%     
- Complexity     1034     1239     +205     
============================================
  Files           254      254              
  Lines         11495    11489       -6     
  Branches       1200     1200              
============================================
+ Hits           2331     2791     +460     
+ Misses         9135     8671     -464     
+ Partials         29       27       -2     
Flag Coverage Δ
integration_tests 24.29% <ø> (+4.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@hisanhunais hisanhunais changed the title Add Config Values for Enable SHA-1 Hashing Algorithm Add Config Values for Enable SHA-256 Hashing Algorithm Mar 28, 2024
@tharikaGitHub tharikaGitHub merged commit e79b5be into wso2:master Mar 28, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants