Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perform SHA-256 Hash for Certificate Signature Validation #13455

Closed
wants to merge 1 commit into from

Conversation

hisanhunais
Copy link
Contributor

Purpose

The PR [1] changed the default certificate hashing algorithm to SHA-256. This PR incorporates that change in to integration tests by performing SHA-256 hashing for certificate signature validation.

This should be merged after merging [1]

[1] wso2/carbon-apimgt#12365

Copy link

codecov bot commented Mar 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 20.52%. Comparing base (06a3b3e) to head (c38f92d).
Report is 359 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #13455      +/-   ##
============================================
+ Coverage     14.50%   20.52%   +6.01%     
- Complexity      748     1039     +291     
============================================
  Files           254      254              
  Lines         11489    11495       +6     
  Branches       1200     1200              
============================================
+ Hits           1667     2359     +692     
+ Misses         9804     9116     -688     
- Partials         18       20       +2     
Flag Coverage Δ
integration_tests 20.52% <ø> (+6.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hisanhunais
Copy link
Contributor Author

The default certificate hashing algorithm was kept as SHA-1 with [1] by reverting the change made to keep the default hashing algorithm as SHA-256. So, this change is not needed. Hence, closing the PR.

[1] wso2/carbon-apimgt#12387

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant