Integration Tests for Throttle Policy Reset Support Feature #13493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto feature-throttle-policy-reset # Conflicts: # modules/integration/tests-integration/tests-backend/src/test/java/org/wso2/am/integration/tests/throttling/ApplicationThrottlingResetTestCase.java
rmsamitha
reviewed
May 22, 2024
| checkThrottling(apiInvocationUrl, requestHeaders, 5); | ||
| } | ||
|
|
||
| @Test(groups = { "wso2.am" }, description = "Test reset application throttling policy with request count limit") |
There was a problem hiding this comment.
Fixed with ea0b01f
rmsamitha
reviewed
May 22, 2024
| @Test(groups = { "wso2.am" }, description = "Test reset application throttling policy with request count limit") | ||
| public void testResetPolicyWithRequestCountLimit() throws Exception { | ||
| //subscribe to API | ||
| SubscriptionDTO subscriptionDTO = restAPIStore.subscribeToAPI(apiId, |
There was a problem hiding this comment.
Move subscription code to setEnvironment method
There was a problem hiding this comment.
Fixed with ea0b01f
rmsamitha
reviewed
May 22, 2024
| requestHeaders.put("accept", "text/xml"); | ||
| requestHeaders.put("content-type", "application/json"); | ||
| String apiInvocationUrl = getAPIInvocationURLHttps(APIContext + "/" + APIVersion + "/"); | ||
|
|
There was a problem hiding this comment.
Code untill here should go to setEnvironment method
There was a problem hiding this comment.
Fixed with ea0b01f
rmsamitha
reviewed
May 22, 2024
| requestHeaders.put("accept", "text/xml"); | ||
| requestHeaders.put("content-type", "application/json"); | ||
| String apiInvocationUrl = getAPIInvocationURLHttps(APIContext + "/" + APIVersion + "/"); | ||
|
|
There was a problem hiding this comment.
Code untill here should go to setEnvironment method
There was a problem hiding this comment.
Fixed with ea0b01f
rmsamitha
reviewed
May 22, 2024
| Map<String, String> requestHeaders = new HashMap<String, String>(); | ||
| requestHeaders.put("Authorization", "Bearer " + accessToken); | ||
| requestHeaders.put("accept", "text/xml"); | ||
| requestHeaders.put("content-type", "application/json"); |
There was a problem hiding this comment.
There are already defined content type constants for the values of these content types
There was a problem hiding this comment.
Fixed with ea0b01f
rmsamitha
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: wso2/api-manager#2455
Related PRs