Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the inconsistency in adding carbon.super to URL when tenant qualified URL is enabled. #16906

Closed
Thisara-Welmilla opened this issue Oct 10, 2023 · 1 comment
Assignees
Milestone

Comments

@Thisara-Welmilla
Copy link
Contributor

Following improvement needs to be done for existing behavior when tenant qualified URLs feature is enabled,

  1. The carbon.super is mandatory to add for some URL paths which leads to the inconsistency.
  2. Some redirection URL also have carbon.super added to URL which is also leads to the inconsistency
    Needs to fix the inconsistency behavior.

Suggested approach.

  1. Add a new config to specify whether carbon.super tenant domain need to be added to the URLs. When the corresponding config is enabled to add the carbon.super in the URL, all inbound/outbound/metadata URL without carbon.super in path must be restricted an vice versa.
  2. By default, the above config have to be disabled.
@Thisara-Welmilla
Copy link
Contributor Author

Thisara-Welmilla commented Oct 10, 2023

PRs:

Fix tenant domain resolving issue when tenanted qualified urls feature is enabled:

Improve feature specify whether carbon.super is required in URLs:

PRs to fix setting root path for cookies:

Others:

@Thisara-Welmilla Thisara-Welmilla added this to the 7.0.0-alpha milestone Nov 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

3 participants