Improve Tenant Resolving Logic during logout for Tenant Qualified URLs #408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR builder started |
|
PR builder completed |
jenkins-is-staging
approved these changes
Oct 19, 2023
There was a problem hiding this comment.
Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/6571467408
chamathns
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will use the resolveTenantDomain method in IdentityTenantUtil to resolve the tenant domain of tenant qualified URLs. When tenant qualified URLs and tenanted sessions are enabled, the super tenant urls will not contain the tenant domain in the request path. Therefore the request will not be used to derive tenant domain, instead it will be retrieved from the context.
Related issue: wso2/product-is#16906