Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix workflow deployment verification and add logs #16041

Merged
merged 3 commits into from
Jun 20, 2023
Merged

Fix workflow deployment verification and add logs #16041

merged 3 commits into from
Jun 20, 2023

Conversation

vinumaddumage
Copy link
Contributor

@vinumaddumage vinumaddumage commented Jun 13, 2023 •
edited
Loading

Purpose

Fix intermittent Integration test failure on UserMeApproval test.

  • Verification of workflow deployment
  • Task creation on user addition.

@vinumaddumage vinumaddumage marked this pull request as ready for review June 15, 2023 06:11
@jenkins-is-staging
Copy link
Contributor

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/5307933068

pulasthi7
pulasthi7 reviewed Jun 19, 2023
View reviewed changes
...a/org/wso2/identity/integration/test/rest/api/user/approval/common/UserApprovalTestBase.java Outdated Show resolved Hide resolved
...a/org/wso2/identity/integration/test/rest/api/user/approval/common/UserApprovalTestBase.java Outdated Show resolved Hide resolved
...a/org/wso2/identity/integration/test/rest/api/user/approval/common/UserApprovalTestBase.java Outdated Show resolved Hide resolved
...a/org/wso2/identity/integration/test/rest/api/user/approval/common/UserApprovalTestBase.java Outdated Show resolved Hide resolved
...a/org/wso2/identity/integration/test/rest/api/user/approval/common/UserApprovalTestBase.java Outdated Show resolved Hide resolved
...a/org/wso2/identity/integration/test/rest/api/user/approval/common/UserApprovalTestBase.java Show resolved Hide resolved
@jenkins-is-staging
Copy link
Contributor

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/5307933068
Status: success

jenkins-is-staging
jenkins-is-staging approved these changes Jun 19, 2023
View reviewed changes
Copy link
Contributor

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/5307933068

@jenkins-is-staging
Copy link
Contributor

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/5309490716

@jenkins-is-staging
Copy link
Contributor

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/5309490716
Status: success

jenkins-is-staging
jenkins-is-staging approved these changes Jun 19, 2023
View reviewed changes
Copy link
Contributor

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/5309490716

@jenkins-is-staging
Copy link
Contributor

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/5311019819

@jenkins-is-staging
Copy link
Contributor

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/5311019819
Status: success

jenkins-is-staging
jenkins-is-staging approved these changes Jun 19, 2023
View reviewed changes
Copy link
Contributor

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/5311019819

@vinumaddumage vinumaddumage merged commit 5676e6b into wso2:master Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pulasthi7 pulasthi7 pulasthi7 approved these changes

@jenkins-is-staging jenkins-is-staging jenkins-is-staging approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vinumaddumage @jenkins-is-staging @pulasthi7