Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate security-mgt module from framework to its own group. #16487

Merged
merged 2 commits into from
Aug 23, 2023
Merged

Migrate security-mgt module from framework to its own group. #16487

merged 2 commits into from
Aug 23, 2023

Conversation

mpmadhavig
Copy link
Contributor

@mpmadhavig mpmadhavig commented Aug 21, 2023 •
edited
Loading

Proposed changes in this pull request

This PR contains the changes made to migrate the security-mgt component from framework and move it to new carbon.security.mgt group. This is a milestone of the following issue[1].

Related Issues

When should this PR be merged

This PR should be merged after the following set of PR got merged and released.

  1. Migrate security-mgt module from framework to its own group. wso2-extensions/identity-metadata-saml2#86
  2. Migrate security-mgt module from framework to its own group. wso2-extensions/identity-tool-samlsso-validator#43
  3. Migrate security-mgt module from framework to its own group. carbon-multitenancy#241
  4. Migrate security-mgt module from framework to its own group. wso2-extensions/identity-inbound-auth-saml#401
  5. Migrate security-mgt module from framework to its own group. wso2-extensions/identity-inbound-auth-sts#140
  6. Migrate security-mgt module from framework to its own group. wso2-extensions/identity-inbound-auth-oauth#2137
  7. Migrate security-mgt module from framework to its own group. wso2-extensions/identity-user-account-association#49
  8. Migrate security-mgt module from framework to its own group. wso2-extensions/identity-inbound-auth-openid#95
  9. Remove security-mgt modules framework and added new one. carbon-identity-framework#4856

@mpmadhavig mpmadhavig force-pushed the migrate-security-mgt-module-group branch from 8bb0c1f to 1a9bc24 Compare August 22, 2023 08:25
@jenkins-is-staging
Copy link
Contributor

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/5936333970

@jenkins-is-staging
Copy link
Contributor

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/5936333970
Status: failure

@jenkins-is-staging
Copy link
Contributor

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/5936333970

@jenkins-is-staging
Copy link
Contributor

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/5936333970
Status: failure

@mpmadhavig mpmadhavig mentioned this pull request Aug 22, 2023
Open
7 tasks
@mpmadhavig mpmadhavig force-pushed the migrate-security-mgt-module-group branch from 1a9bc24 to 9e7390d Compare August 22, 2023 08:41
@jenkins-is-staging
Copy link
Contributor

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/5936504026

@jenkins-is-staging
Copy link
Contributor

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/5936504026
Status: success

jenkins-is-staging
jenkins-is-staging approved these changes Aug 22, 2023
View reviewed changes
Copy link
Contributor

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/5936504026

@mpmadhavig mpmadhavig merged commit 795a35f into wso2:master Aug 23, 2023
1 check passed
@mpmadhavig mpmadhavig mentioned this pull request Sep 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThaminduR ThaminduR ThaminduR approved these changes

@jenkins-is-staging jenkins-is-staging jenkins-is-staging approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mpmadhavig @jenkins-is-staging @ThaminduR