Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Switching to Service Account JSON Credentials #16540

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Commits on Aug 28, 2023

  1. Chore:Switching to Service Account JSON Credentials for GA Packs Down…

    …load from Google Drive during migration automation
    
    Description:
    
    This pull request introduces a pivotal enhancement to the GitHub environment's mechanism for downloading GA packs from Google Drive.
    
    Changes Made:
    
    Transition to Service Account JSON Credentials:
    
    The method for accessing Google Drive has been revamped. Instead of using a GCP API key, we now leverage a Service Account to download files. This is a more secure approach to handle file downloads from Google Drive.
    For this purpose, a dedicated file (creds.json) has been created to securely store the Service Account JSON credentials. This file is located within the .github/migration-tester/migration-automation directory.
    Removal of Old GCP Credentials:
    
    The older method of using the GCP API key, represented by the secrets GCP_CLIENT_ID, GCP_CLIENT_SECRET, and GCP_REFRESH_TOKEN, has been deprecated and removed from the workflow. This change aligns with the shift towards utilizing the Service Account for the file download operations.
    JayanaGunaweera01 committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    30cf55b View commit details
    Browse the repository at this point in the history
  2. Fix: continue-on-error: true

    made continue-on-error value to true.
    JayanaGunaweera01 committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    ebda6fd View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2023

  1. fix: Removed creds.json

    Ensured secure removal of creds.json from .github/workflows.
    JayanaGunaweera01 committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    c08b453 View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2023

  1. refactor: Secure Token Handling and Streamline Script

    Enhanced security by decoding sensitive JSON credentials directly from the environment variable and generating a JWT token for authentication. This eliminates the need to store credentials in a file.(creds.json)
    JayanaGunaweera01 committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    1b056c8 View commit details
    Browse the repository at this point in the history
  2. remove: creds.json

    The removal of the creds.json file was executed because this step has been superseded by the introduction of environment variables when using JSON credentials. This change prevents the storage of JSON credentials within a file, enhancing security.
    JayanaGunaweera01 committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    3db1330 View commit details
    Browse the repository at this point in the history