Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify client ID tenant unification tests to handle new default behavior of tenant qualified URLs #16872

Merged
merged 1 commit into from
Oct 25, 2023

Conversation

ThaminduDilshan
Copy link
Contributor

Integration tests for client ID tenant unification are added with #16632, however these tests expect tenant qualified urls disabled and non tenanted sessions as the default behavior. With the improvement to enable these configs by default, tests need to be modified to invert the server configs.

This PR does that.

Related issues

@ThaminduDilshan ThaminduDilshan marked this pull request as draft October 6, 2023 09:52
@ThaminduDilshan ThaminduDilshan marked this pull request as ready for review October 24, 2023 03:16
@jenkins-is-staging
Copy link
Contributor

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/6621904292

@ThaminduDilshan ThaminduDilshan changed the title [WIP] Modify client ID tenant unification tests to handle new default behavior Modify client ID tenant unification tests to handle new default behavior of tenant qualified URLs Oct 24, 2023
@jenkins-is-staging
Copy link
Contributor

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/6621904292
Status: success

Copy link
Contributor

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/6621904292

@Thisara-Welmilla Thisara-Welmilla merged commit 0001eda into wso2:master Oct 25, 2023
1 check passed
@jenkins-is-staging
Copy link
Contributor

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/9163061271

@jenkins-is-staging
Copy link
Contributor

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/9163061271
Status: cancelled

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants