OIDC FAPI Conformance GitHub action build onboarding #18059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anjuchamantha
changed the title
Thumimku
reviewed
Dec 6, 2023
| # echo "-----------------------------" | ||
| # echo | ||
| # python3 $CONFORMANCE_SUITE_PATH/scripts/run-test-plan.py fapi1-advanced-final-test-plan[client_auth_type=mtls][fapi_profile=plain_fapi][fapi_response_mode=jarm][fapi_auth_request_method=by_value] $PATH_TO_SCRIPTS/config/IS_config_fapi_mtls.json 2>&1 | tee fapi-testplan-mtls-jarm-log.txt | ||
| # echo |
There was a problem hiding this comment.
EOF - check other places
There was a problem hiding this comment.
Fixed with 5655e1a
| python3 $CONFORMANCE_SUITE_PATH/scripts/run-test-plan.py fapi1-advanced-final-test-plan[client_auth_type=mtls][fapi_profile=plain_fapi][fapi_response_mode=plain_response][fapi_auth_request_method=by_value] $PATH_TO_SCRIPTS/config/IS_config_fapi_mtls.json 2>&1 | tee fapi-testplan-mtls-log.txt | ||
| echo | ||
|
|
||
| # echo |
There was a problem hiding this comment.
Currently the PAR and JARM FAPI profiles are not passing, and hence I have added the lines and commented so we just need to uncomment those 2 lines when those profiles are ready.
JARM issue: #18062
|
|
Thumimku
reviewed
Dec 6, 2023
| # echo "-----------------------------" | ||
| # echo | ||
| # python3 $CONFORMANCE_SUITE_PATH/scripts/run-test-plan.py fapi1-advanced-final-test-plan[client_auth_type=mtls][fapi_profile=plain_fapi][fapi_response_mode=jarm][fapi_auth_request_method=by_value] $PATH_TO_SCRIPTS/config/IS_config_fapi_mtls.json 2>&1 | tee fapi-testplan-mtls-jarm-log.txt | ||
| # echo |
There was a problem hiding this comment.
Suggested change
| # echo | |
| # echo | |
There was a problem hiding this comment.
Fixed with 5655e1a
Thumimku
reviewed
Dec 7, 2023
| @@ -0,0 +1,99 @@ | |||
| [server] | |||
There was a problem hiding this comment.
Rather than replacing entire content, can we append require content, we can work this as improvement.
Thumimku
approved these changes
Dec 7, 2023
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR, OIDC FAPI Conformance suite is onboarded as a GitHub action build to this product-is repo.
Issue: #16630