Modify extractClaims to work with regex #18394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR builder started |
|
PR builder completed |
sahandilshan
force-pushed
the
integration-tests2
branch
from
e510c66
to
d2e5be9
Compare
|
PR builder started |
|
PR builder completed |
jenkins-is-staging
approved these changes
Dec 4, 2023
There was a problem hiding this comment.
Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/7085810806
...s-integration/tests-backend/src/test/java/org/wso2/identity/integration/test/util/Utils.java
Outdated
Show resolved
Hide resolved
...s-integration/tests-backend/src/test/java/org/wso2/identity/integration/test/util/Utils.java
Outdated
Show resolved
Hide resolved
Modify the `extractClaims` method to select the div tags that contains the `claim-list` class. With the earlier implementation, if someone add a newer class to the div tag, the tests will get failed. With this implementation, it will check a regex match to identify the claim list, instead of string comparison.
sahandilshan
force-pushed
the
integration-tests2
branch
from
d2e5be9
to
c65599a
Compare
SujanSanjula96
approved these changes
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
extractClaimsmethod to select the div tags that contain theclaim-listclass. With the earlier implementation, the tests will fail if someone adds a newer class to the div tag. This implementation will check a regex match instead of a string comparison to identify the claim list.