Fix dependency updater to update conditional.authentication.functions.version #18596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR builder started |
|
PR builder completed |
jenkins-is-staging
approved these changes
Dec 15, 2023
There was a problem hiding this comment.
Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/7218035353
madurangasiriwardena
approved these changes
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since ${conditional.authentication.functions.version} used for multiple dependencies, all dependencies need to be satisfiable for a particular version of that. If even one dependency cannot be satisfied with the newer version, the plugin would not update the version at all.
The following artifact no longer gets released.
https://maven.wso2.org/nexus/content/repositories/releases/org/wso2/carbon/identity/conditional/auth/functions/org.wso2.carbon.identity.conditional.auth.functions.cookie/
Since this artifact is no longer being released, its latest version would not correspond to the newer version of conditional.authentication.functions.version. As a result, the plugin recognizes that updating the conditional.authentication.functions.version would lead to dependency resolution failures and would not update the property at all.
This PR removes these dependencies so that the mvn version plugin would update the ${conditional.authentication.functions.version}