Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump api server version and fix integration tests #20949

Merged
merged 3 commits into from
Aug 21, 2024

Conversation

shashimalcse
Copy link
Contributor

We have introduced new fields to the access token configuration: wso2/identity-api-server#631. Integration tests are failing due to that. This will fix it.

@jenkins-is-staging
Copy link
Contributor

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/10482793027

@jenkins-is-staging
Copy link
Contributor

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/10482793027
Status: failure

@jenkins-is-staging
Copy link
Contributor

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/10482894597

@darshanasbg
Copy link
Contributor

We have introduced new fields to the access token configuration: wso2/identity-api-server#631. Integration tests are failing due to that. This will fix it.

Causing for a failure of existing integration tests and fixing tests to overcome that, is a indicator to figure we are doing a backward incompatible change, or changing the default behaviour..

@shashimalcse: Could you please point me to a reference that I could get more info on this?

@shashimalcse
Copy link
Contributor Author

shashimalcse commented Aug 21, 2024

We have introduced new fields to the access token configuration: wso2/identity-api-server#631. Integration tests are failing due to that. This will fix it.

Causing for a failure of existing integration tests and fixing tests to overcome that, is a indicator to figure we are doing a backward incompatible change, or changing the default behaviour..

@shashimalcse: Could you please point me to a reference that I could get more info on this?

We are using models in REST API integration tests and we need to change it when we alter the schemas. We have followed the same approach following cases as well

@jenkins-is-staging
Copy link
Contributor

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/10482894597
Status: success

Copy link
Contributor

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/10482894597

@shashimalcse shashimalcse merged commit e5d67a0 into wso2:master Aug 21, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants