Refactor user permission implementation related to pre issue access token action tests #21070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR builder started |
|
PR builder completed |
jenkins-is-staging
approved these changes
Sep 6, 2024
There was a problem hiding this comment.
Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/10738133996
malithie
reviewed
Sep 12, 2024
| .map(String::toLowerCase) | ||
| .collect(Collectors.joining(" ")); | ||
| parameters.add(new BasicNameValuePair("scope", scopes)); | ||
| parameters.add(new BasicNameValuePair("scope", String.join(" ", permissions))); |
There was a problem hiding this comment.
Looks like permissions is an empty list. Isn't that the case ?
|
@Shenali-SJ this PR seems to be conflicted now. |
Shenali-SJ
force-pushed
the
actions-integration-tests
branch
from
da2e5b8
to
85f086f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This refactors the implementation of user permission handling in both the
preIssueAccessTokenPasswordGrantTestCaseandpreIssueAccessTokenClientCredentialsGrantTestCase.Related Issues
Related PRs