Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update pre issue access token password grant test. #21091

Merged
merged 1 commit into from
Sep 12, 2024
Merged

Update pre issue access token password grant test. #21091

merged 1 commit into from
Sep 12, 2024

Conversation

malithie
Copy link
Member

@malithie malithie commented Sep 11, 2024 •
edited
Loading

Relates to #20842

This PR,

  • Validates request initiated for the external endpoint that implements pre issue access token action. Several model classes are introduced with this.
  • Refactor actions mock server

Kindly note this PR adds minimal refactoring and improvements to make sure the respective functionality is covered. This can be improved more as other cases are covered

@jenkins-is-staging
Copy link
Contributor

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/10815897430

@jenkins-is-staging
Copy link
Contributor

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/10815897430
Status: success

jenkins-is-staging
jenkins-is-staging approved these changes Sep 11, 2024
View reviewed changes
Copy link
Contributor

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/10815897430

@jenkins-is-staging
Copy link
Contributor

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/10823323280

@jenkins-is-staging
Copy link
Contributor

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/10823323280
Status: failure

@jenkins-is-staging
Copy link
Contributor

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/10823323280

@jenkins-is-staging
Copy link
Contributor

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/10823323280
Status: success

jenkins-is-staging
jenkins-is-staging approved these changes Sep 12, 2024
View reviewed changes
Copy link
Contributor

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/10823323280

@malithie malithie merged commit fa3016d into wso2:master Sep 12, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jenkins-is-staging jenkins-is-staging jenkins-is-staging approved these changes

@ashanthamara ashanthamara ashanthamara approved these changes

@Shenali-SJ Shenali-SJ Awaiting requested review from Shenali-SJ

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@malithie @jenkins-is-staging @ashanthamara