-
Notifications
You must be signed in to change notification settings - Fork 720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate jacoco report in conformance suite #21102
Generate jacoco report in conformance suite #21102
Conversation
Maduranga Siriwardena seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
416591e
to
a4a9dc8
Compare
...jacoco-report-generator/src/main/java/org/wso2/carbon/identity/jacoco/CodeCoverageUtils.java
Outdated
Show resolved
Hide resolved
...jacoco-report-generator/src/main/java/org/wso2/carbon/identity/jacoco/CodeCoverageUtils.java
Outdated
Show resolved
Hide resolved
...jacoco-report-generator/src/main/java/org/wso2/carbon/identity/jacoco/CodeCoverageUtils.java
Outdated
Show resolved
Hide resolved
...jacoco-report-generator/src/main/java/org/wso2/carbon/identity/jacoco/CodeCoverageUtils.java
Outdated
Show resolved
Hide resolved
...n/jacoco-report-generator/src/main/java/org/wso2/carbon/identity/jacoco/ReportGenerator.java
Outdated
Show resolved
Hide resolved
95172be
to
2f51345
Compare
...n/jacoco-report-generator/src/main/java/org/wso2/carbon/identity/jacoco/ReportGenerator.java
Outdated
Show resolved
Hide resolved
...n/jacoco-report-generator/src/main/java/org/wso2/carbon/identity/jacoco/ReportGenerator.java
Outdated
Show resolved
Hide resolved
...jacoco-report-generator/src/main/java/org/wso2/carbon/identity/jacoco/CodeCoverageUtils.java
Outdated
Show resolved
Hide resolved
...jacoco-report-generator/src/main/java/org/wso2/carbon/identity/jacoco/CodeCoverageUtils.java
Outdated
Show resolved
Hide resolved
...jacoco-report-generator/src/main/java/org/wso2/carbon/identity/jacoco/CodeCoverageUtils.java
Outdated
Show resolved
Hide resolved
2f51345
to
5d53b85
Compare
5d53b85
to
eca3a88
Compare
|
||
for (File classDirectory : classDirectories) { | ||
// Jar files to analyze | ||
File[] files = classDirectory.listFiles((dir, name) -> name.startsWith("org.wso2.carbon") && !name.contains(".stub_")); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
have we considered ignoring carbon ui components?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can ignore them during the report analysis level at the module repository level.
...jacoco-report-generator/src/main/java/org/wso2/carbon/identity/jacoco/CodeCoverageUtils.java
Outdated
Show resolved
Hide resolved
*/ | ||
public void create() throws IOException { | ||
|
||
// Read the jacoco.exec file. Multiple data files could be merged |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These comments can be moved as method comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is better suited to explain the method invocation. Improved the method comment with #21108
|
||
private void createReport(final IBundleCoverage bundleCoverage) throws IOException { | ||
|
||
// Create a concrete report visitor based on some supplied |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move as method comment?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done with #21108
* @return - Jar file extracted directory. | ||
* @throws IOException - Throws if jar extraction fails | ||
*/ | ||
public synchronized static String extractJarFile(String jarFilePath, File tempDir) throws IOException { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we really need this to be synchronized
here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done with #21108
Part of #21117