-
Notifications
You must be signed in to change notification settings - Fork 720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[integration tests] Pre issue access token with auth code grant type #21115
base: master
Are you sure you want to change the base?
Conversation
fc183d9
to
0e5af1c
Compare
PR builder started |
e76b3a3
to
b82f2a1
Compare
b82f2a1
to
6d73f32
Compare
PR builder completed |
PR builder started |
PR builder completed |
PR builder started |
PR builder completed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/10954597109
try { | ||
Thread.sleep(3600); | ||
} catch (InterruptedException e) { | ||
Thread.currentThread().interrupt(); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do we have this ?
.accessToken(accessTokenInRequest) | ||
.tenant(tenant) | ||
.organization(null) | ||
.user(user) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For client credentials ideally there should not be a user
Is there a user in the request ?
|
||
try { | ||
Thread.sleep(3600); | ||
} catch (InterruptedException e) { | ||
Thread.currentThread().interrupt(); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do we have this
.skipConsent(true) | ||
.build(); | ||
|
||
appTokenScopes = new TokenScopes.Builder().requestedScopes(Arrays.asList(OPENID_SCOPE, PROFILE_SCOPE, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we have this inside this method ? And can't see any usages of this.
Description
This adds integration tests for the pre issue access token action execution flow with the authorization code grant type.
This covers the test cases for the following scenarios.
aud
claimexpires_in
claimA mock server has been set up using Wiremock to simulate the external service. The mock server runs locally on the port
8587
.Related Issue