Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[integration tests] Pre issue access token with auth code grant type #21115

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

Shenali-SJ
Copy link
Contributor

Description

This adds integration tests for the pre issue access token action execution flow with the authorization code grant type.
This covers the test cases for the following scenarios.

  • Add, replace, remove custom scopes
  • Add, replace, remove aud claim
  • Add custom claims - (data types supported: string, number, boolean, string array)
  • Replace expires_in claim

A mock server has been set up using Wiremock to simulate the external service. The mock server runs locally on the port 8587.

Related Issue

@jenkins-is-staging
Copy link
Contributor

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/10889799691

@CLAassistant
Copy link

CLAassistant commented Sep 16, 2024

CLA assistant check
All committers have signed the CLA.

@jenkins-is-staging
Copy link
Contributor

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/10889799691
Status: failure

@jenkins-is-staging
Copy link
Contributor

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/10933030325

@jenkins-is-staging
Copy link
Contributor

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/10933030325
Status: failure

@jenkins-is-staging
Copy link
Contributor

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/10954597109

@jenkins-is-staging
Copy link
Contributor

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/10954597109
Status: success

Copy link
Contributor

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/10954597109

Comment on lines +236 to +240
try {
Thread.sleep(3600);
} catch (InterruptedException e) {
Thread.currentThread().interrupt();
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we have this ?

.accessToken(accessTokenInRequest)
.tenant(tenant)
.organization(null)
.user(user)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For client credentials ideally there should not be a user
Is there a user in the request ?

Comment on lines +246 to +251

try {
Thread.sleep(3600);
} catch (InterruptedException e) {
Thread.currentThread().interrupt();
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we have this

.skipConsent(true)
.build();

appTokenScopes = new TokenScopes.Builder().requestedScopes(Arrays.asList(OPENID_SCOPE, PROFILE_SCOPE,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we have this inside this method ? And can't see any usages of this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants