Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add access token attributes integration test #21446

Merged
merged 9 commits into from
Nov 13, 2024
Merged

Add access token attributes integration test #21446

merged 9 commits into from
Nov 13, 2024

Conversation

mpmadhavig
Copy link
Contributor

@mpmadhavig mpmadhavig mentioned this pull request Oct 22, 2024
Closed
@mpmadhavig mpmadhavig mentioned this pull request Oct 25, 2024
Merged
@jenkins-is-staging
Copy link
Contributor

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/11553067108

@jenkins-is-staging
Copy link
Contributor

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/11553067108
Status: failure

@mpmadhavig mpmadhavig force-pushed the jwt-claims branch 2 times, most recently from 7a3194b to b58a794 Compare October 28, 2024 12:38
@jenkins-is-staging
Copy link
Contributor

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/11553067108

@jenkins-is-staging
Copy link
Contributor

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/11553067108
Status: failure

@jenkins-is-staging
Copy link
Contributor

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/11553067108

@jenkins-is-staging
Copy link
Contributor

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/11553067108
Status: failure

malithie
malithie reviewed Oct 29, 2024
View reviewed changes
.../org/wso2/identity/integration/test/oauth2/OAuth2AuthorizationCodeGrantJWTTokenTestCase.java Outdated
assertEquals(accessTokenClaims.getClaim(claim.getOidcClaimUri()),
authorizingUser.getUserClaims().get(claim),
"Value for claim " + claim.getOidcClaimUri() + " is incorrect in the access token.");
"User claim " + claim.getOidcClaimUri() + " not found in the access token.");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mpmadhavig why assert equals is removed ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has been missed during e refactoring effort. Fixed with 52ebe10

Copilot
Copilot AI reviewed Nov 6, 2024
View reviewed changes

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 7 changed files in this pull request and generated no suggestions.

Files not reviewed (2)
  • modules/integration/tests-integration/tests-backend/src/test/resources/testng.xml: Language not supported
  • pom.xml: Language not supported
@mpmadhavig mpmadhavig mentioned this pull request Nov 11, 2024
Merged
shashimalcse
shashimalcse previously approved these changes Nov 12, 2024
View reviewed changes
@jenkins-is-staging
Copy link
Contributor

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/11809032871

@jenkins-is-staging
Copy link
Contributor

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/11809032871
Status: failure

@jenkins-is-staging
Copy link
Contributor

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/11809061328

@jenkins-is-staging
Copy link
Contributor

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/11809061328
Status: failure

@jenkins-is-staging
Copy link
Contributor

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/11809061328

Thumimku
Thumimku previously approved these changes Nov 13, 2024
View reviewed changes
Copy link
Contributor

@Thumimku Thumimku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's merge after integration test passed.

@jenkins-is-staging
Copy link
Contributor

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/11809061328
Status: success

jenkins-is-staging
jenkins-is-staging approved these changes Nov 13, 2024
View reviewed changes
Copy link
Contributor

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/11809061328

Thumimku
Thumimku approved these changes Nov 13, 2024
View reviewed changes
Copy link
Contributor

@Thumimku Thumimku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's run the integration tests and merge

@mpmadhavig mpmadhavig merged commit 4158508 into wso2:master Nov 13, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot Copilot left review comments

@malithie malithie malithie left review comments

@jenkins-is-staging jenkins-is-staging jenkins-is-staging approved these changes

@Thumimku Thumimku Thumimku approved these changes

@shashimalcse shashimalcse shashimalcse left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mpmadhavig @jenkins-is-staging @malithie @Thumimku @shashimalcse