Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve cancel scan and logging of Veracode scanner #127

Merged
merged 7 commits into from
Jun 26, 2019

Conversation

NShani
Copy link
Contributor

@NShani NShani commented Jun 19, 2019

Purpose

  • In the scanner micro service API, it needs to update the scan manager with the logging details. This can be implemented by a log appender. Requests that are coming to the scanner micro service API should be validated in the scanner layer. These common things should be enforced by the Scanner interface.

Goals

  • Persisting scanner logs is a common feature is in all the scanners. So CallbackLogAppender will do the persisting scanner's log in the scan manager. Further this PR improves the scanner interface to do some implementation level enforcement.

Approach

Improve the common scanner classes to enforce the required architecture.

User stories

Release note

Documentation

Training

Certification

Marketing

Automation tests

  • Unit tests
  • Integration tests

Security checks

Samples

Related PRs

Migrations (if applicable)

Test environment

Learning

@codecov
Copy link

codecov bot commented Jun 20, 2019

Codecov Report

Merging #127 into master will decrease coverage by 2.41%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #127      +/-   ##
==========================================
- Coverage   28.83%   26.42%   -2.42%     
==========================================
  Files          34       36       +2     
  Lines         756      825      +69     
  Branches       28       34       +6     
==========================================
  Hits          218      218              
- Misses        532      601      +69     
  Partials        6        6
Impacted Files Coverage Δ
...scanmanager/scanners/common/ScannerController.java 0% <0%> (ø) ⬆️
...ols/scanmanager/scanners/common/util/FileUtil.java 0% <0%> (ø) ⬆️
...scanmanager/scanners/common/model/CallbackLog.java 0% <0%> (ø)
...scanmanager/scanners/common/util/CallbackUtil.java 0% <0%> (ø) ⬆️
...r/scanners/common/logging/CallbackLogAppender.java 0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4eddbe0...d550221. Read the comment docs.

NShani and others added 3 commits June 24, 2019 14:17
…ecurity/tools/scanmanager/scanners/common/ScannerController.java

Co-Authored-By: Ayoma Wijethunga <ayomawdb@gmail.com>
@ayomawdb ayomawdb merged commit 51dece7 into wso2:master Jun 26, 2019
@ayomawdb ayomawdb changed the title Scanner veracode Improve cancel scan and logging of Veracode scanner Jun 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants