Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for issue 28 #29

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix for issue 28 #29

wants to merge 3 commits into from

Conversation

indika-dev
Copy link

Purpose

Fix for #28

Goals

WSDL from #28 is parsed correctly

Approach

added a check on 0 for path.length in org.wso2.soaptorest.SOAPRequestBodyGenerator:353

User stories

N/A

Release note

fix #28

Documentation

N/A

Training

N/A

Certification

N/A because I don't know, if this is needed

Marketing

N/A

Automation tests

  • Unit tests

    added org.wso2.soaptorest.SOAPToRESTConverterTest.testIssue28() and src/test/resources/issue-28/failing.wsdl from bugreport

  • Integration tests

    N/A

Security checks

Samples

N/A

Related PRs

N/A

Migrations (if applicable)

N/A

Test environment

Oracle JDK 17.0.12

Learning

Looked at code and saw, that a check was missing for values out of a distinct interval which should be either handled by a warning message or a default value

@CLAassistant
Copy link

CLAassistant commented Aug 26, 2024

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WSDL not parseable
2 participants