Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for GE P-file rev 29.1 & 30.0 #117

Merged
merged 2 commits into from
Nov 7, 2023
Merged

Conversation

hfxcarl
Copy link
Contributor

@hfxcarl hfxcarl commented Nov 3, 2023

Added support for GE revision 29.1 and 30.0.

added support for rev 29,30
added rev29.1, 30.0
@hfxcarl
Copy link
Contributor Author

hfxcarl commented Nov 3, 2023

Can test with this rev 30.0 p-file, please delete after testing. Thanks.

@wtclarke
Copy link
Owner

wtclarke commented Nov 3, 2023

Hi @hfxcarl , thanks for making this PR. Someone else recently reported similar. Any chance that you have a phantom dataset that could be used as a long-term test dataset?

@hfxcarl
Copy link
Contributor Author

hfxcarl commented Nov 3, 2023

Hi @wtclarke, I don't have a phantom dataset from the GE MR scanner at rev-30.0, but can request one be collected for sharing. Thanks for the quick response!

@wtclarke wtclarke merged commit d176e14 into wtclarke:master Nov 7, 2023
4 checks passed
@wtclarke
Copy link
Owner

wtclarke commented Nov 7, 2023

I've heard from a highly reliable source that the headers are the same for the MRS relevant fields. So on that basis I'll merge this. I'll get a new version out shortly. Thanks again, and if you do have a test piece of data that could be public it would still be very helpful

@hfxcarl
Copy link
Contributor Author

hfxcarl commented Nov 7, 2023

Hi @wtclarke, Awesome, thank you! Here is an anonymized phantom data from GE 1.5T revision 30.0 using the PRESS seq with TE=30 that you use for testing. In case it's helpful for debugging, I've dumped the anonymized headers to a .json file using the proprietary GE orchestra library from python. Feel free to keep and use as you like. Let me know if you have any questions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants