Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hbcd psd was left in the GE/ge_pfile/_process_gaba() list. #140

Closed
wants to merge 14 commits into from

Conversation

agudmundson
Copy link
Contributor

'hbcd' psd was left in the GE/ge_pfile/_process_gaba() list. Updated. Should only be included in the _process_hbcd list.

agudmundson and others added 14 commits July 21, 2023 11:41
Updated functionality to correctly handle "Dim_" across each sub experiment.
Added Hyper Echo Time for Long TE
Adding functionality to handle GE ISTHMUS/Hyper data. A new custom (_process_hbcd) function for handling the data has been added to the ge_pfile.py. I've also included version 30.x into the get_hdr_fields.py.
Remove added line
Merge in updates to handled python versions and numpy (2.0) compatibility.:
@wtclarke
Copy link
Owner

wtclarke commented Jul 3, 2024

Sorry that must have been a mistake when I was merging conflicts from your fork.

I'm going to close this, but can you reopen using a new branch so it's not tangled up with all the old commits? To do this do locally set up:

git clone https://github.com/agudmundson/spec2nii.git
cd spec2nii
git remote add upstream https://github.com/wtclarke/spec2nii.git
git remote -v

You should see a remote 'origin' that points to your own fork, and a remote upstream which points to the main repo

Then whenever you want to work on a new feature or bug fix

git fetch upstream
git checkout -b {name of new branch} upstream/master

Do the work / fix

git add .
git commit -m "message"
git push origin HEAD

Then open a PR on that branch. That branch is then discarded once you have worked on that feature or fix.

I.e. you have a new branch that starts from the current state of the main master branch.

@wtclarke wtclarke closed this Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants