Missed a PSD in ge_read_pfile.py - adding in for hbcd2 #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Got any example data we can add to prevent regressions sneaking in? |
|
Good idea - the dataset I was just working on was just a phantom, so let me check with the owner if I'm able to add. |
|
Any news on the dataset?
From: Aaron Gudmundson, PhD ***@***.***>
Date: Wednesday, 10 July 2024 at 15:45
To: wtclarke/spec2nii ***@***.***>
Cc: William Clarke ***@***.***>, Comment ***@***.***>
Subject: Re: [wtclarke/spec2nii] Missed a PSD in ge_read_pfile.py - adding in for hbcd2 (PR #145)
Good idea - the dataset I was just working on was just a phantom, so let me check with the owner if I'm able to add.
—
Reply to this email directly, view it on GitHub<#145 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AFJJTTWWHJWAJM2C6EG25NLZLVCGJAVCNFSM6AAAAABKVBJCLGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMRQG4YDSNRRGY>.
You are receiving this because you commented.Message ID: ***@***.***>
|
|
@wtclarke, did this ever get merged? |
|
No, I'm quite keen to include data for regression testing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Missed a PSD in ge_read_pfile.py - adding in for hbcd2... hopefully this will be the last fix for the GE hbcd sequence!