FIX:UnicodeDecodeError while converting rda files #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @gaunab , thanks for the PR that's super useful. Could you a) provide any test data for this, and tweak this commit to undo all the formatting so that it's just the code changes? |
added 2 commits
September 19, 2023 13:14
Where should I send the test data? |
|
You can send it to the email listed at https://www.win.ox.ac.uk/people/william-clarke. Thanks |
|
Hi @gaunab did you send me any test data? Sorry if I missed an email. |
|
P.s. this PR seems to have got a little mangled, reverting ym most recent commit, so I have made a new PR #112 that implements just your fix. Before merging I will wait on some test data. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the UnixodeDecodeError while loading rda-Files:
#96 (comment)