-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
merge from develop #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Credentials model 🐛 fix(config.yml): add username field to artifacts.repo to fix missing username error 🐛 fix(models.py): remove Credentials model as it is no longer used 🐛 fix(settings.py): remove unused import and unused code related to merging secrets
Error types and docstrings also added
also modified the create mutation
changing name and/or path is not yet implemented
when inputting package information to graphql mutations, the id field is optional
Incorporated the use of this mutation into the create environment mutation
create_artifacts returns oid of new commit
also remove overwrite option
fixed a couple errors tox found also
Bootstrapping Fix
Add missing dependency to poetry lock file.
Split input packagename@version to separate Package fields.
Allow multiple spaces after module-whatis and puts stderr statements.
Determine environment state from artifacts. Only queued and ready states implemented so far.
New updateFromModule endpoint. New writeArtifacts endpoint.
Add upload endpoint for builder to pass artifacts to be uploaded to repo.
mjkw31
previously approved these changes
Sep 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Merge main commits from develop back to develop. Make CI run on PRs against develop.
Deploying with Cloudflare Pages
|
mjkw31
approved these changes
Sep 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Codecov ReportAttention:
📢 Thoughts on this report? Let us know!. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.