Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge from develop #26

Merged
merged 142 commits into from
Sep 26, 2023
Merged

merge from develop #26

merged 142 commits into from
Sep 26, 2023

Conversation

sb10
Copy link
Contributor

@sb10 sb10 commented Sep 26, 2023

No description provided.

altaf-ali and others added 30 commits July 4, 2023 12:04
…Credentials model

🐛 fix(config.yml): add username field to artifacts.repo to fix missing username error
🐛 fix(models.py): remove Credentials model as it is no longer used
🐛 fix(settings.py): remove unused import and unused code related to merging secrets
Error types and docstrings also added
also modified the create mutation
changing name and/or path is not yet implemented
when inputting package information to graphql mutations, the id field is optional
Incorporated the use of this mutation into the create environment mutation
create_artifacts returns oid of new commit
also remove overwrite option
fixed a couple errors tox found also
sb10 and others added 19 commits September 7, 2023 15:48
Add missing dependency to poetry lock file.
Split input packagename@version to separate Package fields.
Allow multiple spaces after module-whatis and puts stderr statements.
Determine environment state from artifacts.

Only queued and ready states implemented so far.
New updateFromModule endpoint.

New writeArtifacts endpoint.
Add upload endpoint for builder to pass artifacts to be uploaded to repo.
@sb10 sb10 requested a review from mjkw31 September 26, 2023 09:45
mjkw31
mjkw31 previously approved these changes Sep 26, 2023
Copy link
Contributor

@mjkw31 mjkw31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Sep 26, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 2ec5bf1
Status: ✅  Deploy successful!
Preview URL: https://edd53a8c.softpack-core.pages.dev
Branch Preview URL: https://develop.softpack-core.pages.dev

View logs

Copy link
Contributor

@mjkw31 mjkw31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

Attention: 190 lines in your changes are missing coverage. Please review.

Files Coverage Δ
softpack_core/config/models.py 100.00% <100.00%> (ø)
softpack_core/schemas/package_collection.py 88.46% <ø> (ø)
softpack_core/spack.py 94.11% <ø> (-0.12%) ⬇️
softpack_core/config/settings.py 80.00% <0.00%> (+1.05%) ⬆️
softpack_core/ldapapi.py 34.78% <0.00%> (-14.11%) ⬇️
softpack_core/module.py 91.83% <91.83%> (ø)
softpack_core/service.py 70.00% <47.05%> (-30.00%) ⬇️
softpack_core/artifacts.py 45.02% <34.74%> (-16.31%) ⬇️
softpack_core/schemas/environment.py 51.26% <45.45%> (-28.74%) ⬇️

📢 Thoughts on this report? Let us know!.

@mjkw31 mjkw31 merged commit fc4ec4e into main Sep 26, 2023
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants