Automatically update spack package repo #30

mjkw31 · 2023-10-13T10:52:08Z

No description provided.

codecov · 2023-10-13T10:55:54Z

Codecov Report

Attention: 22 lines in your changes are missing coverage. Please review.

Files	Coverage Δ
softpack_core/app.py	`100.00% <ø> (ø)`
softpack_core/artifacts.py	`45.02% <100.00%> (ø)`
softpack_core/config/models.py	`100.00% <100.00%> (ø)`
softpack_core/config/settings.py	`80.35% <100.00%> (+0.35%)`	⬆️
softpack_core/main.py	`100.00% <ø> (ø)`
softpack_core/schemas/package_collection.py	`91.30% <80.00%> (+2.84%)`	⬆️
softpack_core/spack.py	`52.27% <51.16%> (-41.85%)`	⬇️

📢 Thoughts on this report? Let us know!.

sb10

Should also document all our changes to core, esp. the new config options and new behaviours, in the docs repo.

softpack_core/app.py

softpack_core/schemas/package_collection.py

mjkw31 added 5 commits October 12, 2023 14:02

Add test for existing load_collection implementation.

4e184d1

WIP: Load spack recipes using spack command.

9a7535d

Remove old code + delint.

002bb77

Update package list on a fixed interval.

df191de

Security upgrade urllib3 from 2.0.3 to 2.0.6

6ae787b

mjkw31 requested a review from altaf-ali as a code owner October 13, 2023 10:52

mjkw31 requested a review from sb10 October 13, 2023 10:52

sb10 changed the title ~~Automatically update sapck package repo~~ Automatically update spack package repo Oct 13, 2023

sb10 requested changes Oct 16, 2023

View reviewed changes

softpack_core/app.py Outdated Show resolved Hide resolved

softpack_core/schemas/package_collection.py Outdated Show resolved Hide resolved

mjkw31 added 2 commits October 16, 2023 09:40

Keep iter() return as an iterator.

72d3c6a

Correct the docstring for Application.main

859eea2

sb10 approved these changes Oct 16, 2023

View reviewed changes

sb10 merged commit c3a1338 into develop Oct 16, 2023
1 of 3 checks passed

sb10 deleted the update-spack-repo branch October 16, 2023 12:09